Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-124253 - Rename/Reparent a prim and still have it on its Display… #2459

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

seando-adsk
Copy link
Collaborator

MAYA-124253 - Rename/Reparent a prim and still have it on its Display Layer

  • Added test for Display Layer Ufe item (non-Maya) reparent/rename/delete.

… Layer

* Added test for Display Layer Ufe item (non-Maya) reparent/rename/delete.
@seando-adsk seando-adsk added the unit test Related to unit tests (both python or c++) label Jul 5, 2022
@seando-adsk seando-adsk requested a review from ppt-adsk July 5, 2022 18:53
Comment on lines +106 to +110
if (MAYA_HAS_DISPLAY_LAYER_API)
list(APPEND TEST_SCRIPT_FILES
testDisplayLayer.py
)
endif()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new test if Maya has the Display layer support.

Comment on lines +51 to +52
@unittest.skipUnless(mayaUtils.ufeSupportFixLevel() >= 2, "Requires Display Layer Ufe item rename fix.")
def testDisplayLayerItemRename(self):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test requires a fix I have in Maya for the rename.

self.assertFalse('|stage1|stageShape1,/Sphere1' in layerObjs)
self.assertTrue('|stage1|stageShape1,/NewSphere1' in layerObjs)

def testDisplayLayerItemReparent(self):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test (and one below) work with current Maya code.

Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test!

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Jul 6, 2022
@seando-adsk seando-adsk merged commit d507485 into dev Jul 6, 2022
@seando-adsk seando-adsk deleted the donnels/MAYA-124253/display_layer_unit_test branch July 6, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants