T bailp/maya 123815/reparent on deactivated #2419
Conversation
When the USD prim is deactivated, many operations will crash if called on that prim, as the USD prim API assumes that many of its functions are illegal to call on an invalid prim abd deactivated prim are invalid. (Internally, the UsdPrim contains a pointer which is null when invalid, and most function don't check the pointer, instead relying on the caller to not call them when invalid.) So check the prim validity in parent() and when creating sibling iterators.
| else | ||
| return Hierarchy::createItem(fItem->path().pop()); |
There was a problem hiding this comment.
Not sure why this is correct. If we have an invalid prim, shouldn't we return a nullptr as its parent?
There was a problem hiding this comment.
I hit this case while investigating. I did not write down the exact circumstances (I think you could use the repro steps of the Maya JIRA ticket with a breakpoint in this function without my code changes.) The path parent is valid, but not the path. It was breaking checking if a node had children, IIRC.
There was a problem hiding this comment.
I can see that happening with the child of an inactive prim. Attempting to use that prim would be invalid, its parent would not. I suspect we are hiding a bug with this code... We are not checking that the parent path is valid. I would return a nullptr and see what breaks.
There was a problem hiding this comment.
The call was correct. It was trying to get the parent of the deactivated prim, IIRC. The deactivated prim has a parent, so we should not fail the call.
There was a problem hiding this comment.
But the deactivated prim is still valid, so we should never get into that branch of the conditional.
There was a problem hiding this comment.
Indeed, and yet I got into that situation, otherwise I'd not change the code :). IDK how I got there during my investigations, honestly. (and unfortunately, blame my bad memory)
Made prim validity tests less redundants.
|
Only failure is the known Linux 2022 interactive test. |
No description provided.