Unauthored attrs changes #2414
Merged
Unauthored attrs changes #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the UsdAttribute class. Also applied some code review feedback.
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
ppt-adsk
previously approved these changes
Jun 15, 2022
ppt-adsk
requested changes
Jun 15, 2022
test/lib/ufe/testAttribute.py
Outdated
| @@ -358,6 +358,7 @@ def testAttributeEnumString(self): | |||
| # Use our engine method to run the bulk of the test (all the stuff from | |||
| # the Attribute base class). We use the visibility attribute which is | |||
| # an EnumString type. | |||
| import pdb ; pdb.set_trace() | |||
There was a problem hiding this comment.
Debugging code, please remove.
ppt-adsk
approved these changes
Jun 15, 2022
hodoulp
reviewed
Jun 16, 2022
| std::string typeName() const; | ||
| std::string defaultValue() const; | ||
| bool get(PXR_NS::VtValue& value, PXR_NS::UsdTimeCode time) const; | ||
| bool set(const PXR_NS::VtValue& value, PXR_NS::UsdTimeCode time); |
There was a problem hiding this comment.
Should all these new methods be protected by UFE_V4_FEATURES_AVAILABLE?
| UsdAttribute(const PXR_NS::UsdAttribute& usdAttr); | ||
| ~UsdAttribute() = default; | ||
|
|
||
| inline bool isAuthored() const { return isValid() && fUsdAttr.IsAuthored(); } |
There was a problem hiding this comment.
Should all the following methods be defined in UFE_ATTRIBUTE_OVERRIDES ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.