MAYA-123507 - PluginLight needs to use the Light Icon instead of falling back to Xform icon #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing back to the Xform Icon * Added icon for PluginLight. * Fix case where AL plugin is not built. * Removed unneeded test property.
seando-adsk
commented
Jun 9, 2022
test/lib/ufe/testUIIcons.py
Outdated
| @@ -114,7 +112,7 @@ def testUIIcons(self): | |||
| ('NurbsPatch', 'out_USD_NurbsPatch.png'), | |||
| ('OpenVDBAsset', 'out_USD_UsdGeomXformable.png'), | |||
| ('PackedJointAnimation', 'out_USD_SkelAnimation.png'), | |||
| ('PluginLight', 'out_USD_UsdGeomXformable.png' if usdVer >= (0, 21, 11) else 'out_USD_UsdLuxLight.png'), | |||
| ('PluginLight', 'out_USD_PluginLight.png' if usdVer >= (0, 21, 11) else 'out_USD_UsdLuxLight.png'), | |||
There was a problem hiding this comment.
PluginLight now has an icon.
Comment on lines
+147
to
+153
| # Special case for node types which are in an AL schema. | ||
| # They aren't available when compiling without the AL plugin. | ||
| if Usd.SchemaRegistry.IsConcrete(Tf.Type.FindByName('AL_usd_FrameRange')): | ||
| primTypes.extend([ | ||
| ('ALExamplePolyCubeNode', 'out_USD_UsdTyped.png'), | ||
| ('ALFrameRange', 'out_USD_UsdTyped.png') | ||
| ]) |
There was a problem hiding this comment.
If you build locally without the AL plugin you won't have the schema that defines these two node types.
boudrey
reviewed
Jun 9, 2022
| # Prim Type # Icon file name | ||
| ('ALExamplePolyCubeNode', 'out_USD_UsdTyped.png'), | ||
| ('ALFrameRange', 'out_USD_UsdTyped.png'), | ||
| # Prim Type # Icon file name | ||
| ('ALMayaReference', 'out_USD_MayaReference.png'), |
There was a problem hiding this comment.
What about the ALMayaReference? Should it be moved too?
There was a problem hiding this comment.
The schema for that one is in lib, so its always there.
boudrey
previously approved these changes
Jun 9, 2022
…ing back to the Xform Icon * Use PluginLight icon for any USD version.
seando-adsk
commented
Jun 10, 2022
| @@ -182,6 +182,7 @@ Ufe::UIInfoHandler::Icon UsdUIInfoHandler::treeViewIcon(const Ufe::SceneItem::Pt | |||
| { "ALMayaReference", "out_USD_MayaReference.png" }, // Same as mayaRef | |||
| { "Mesh", "out_USD_Mesh.png" }, | |||
| { "NurbsPatch", "out_USD_NurbsPatch.png" }, | |||
| { "PluginLight", "out_USD_PluginLight.png" }, | |||
There was a problem hiding this comment.
Oops realized (after running preflight) that I forgot to add the icon here. This makes it work no matter what the USD version.
boudrey
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-123507 - PluginLight needs to use the Light Icon instead of falling back to the Xform Icon