-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr/show nested subcomponents in expanded representation #2289
Pr/show nested subcomponents in expanded representation #2289
Conversation
GetRenderTag is a function defined in HdRprim, but the callsite has been moved from classes derived from HdRprim to a different parent class. Pass the render tag into the _SyncSharedData from the HdRprim derived classes to fix the build
Prior to this change, top level subcomponents would be collapsed, hiding all of its children. Now, nested subcomponents will be found and included in Expanded representations of scene assemblies
This branch is tracking https://github.com/dj-mcg/maya-usd/tree/pr/Pass_RenderTag_To_Common_Sync_Fn in order to build. Please let me know if you'd prefer I re-submit this branch once the build failure is addressed |
Hey folks, please let me know if I need to resubmit this PR, thanks so much! |
Hi, it looks like some remote builds are failing to launch in pre-flight for some reason. Is this something I need to resolve on my end? |
No, there is an issue with the preflight system yesterday. I believe it is fixed now so I launched another run. |
// Get the exclude ancestor's proxy shape node. | ||
SdfPath excludeAncestorPath = entry.first; | ||
SdfPath proxyShapePath = excludeAncestorPath.AppendChild( | ||
TfToken(TfStringPrintf("%sProxy", excludeAncestorPath.GetName().c_str()))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason "Proxy" is not in the local _tokens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I can add it if you prefer!
OK I tokenized that "Proxy" suffix, please have another look @williamkrick - thanks! |
No description provided.