Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/show nested subcomponents in expanded representation #2289

Conversation

dj-mcg
Copy link
Collaborator

@dj-mcg dj-mcg commented Apr 12, 2022

No description provided.

dj-mcg added 2 commits April 12, 2022 16:24
GetRenderTag is a function defined in HdRprim, but the callsite has been
moved from classes derived from HdRprim to a different parent class.
Pass the render tag into the _SyncSharedData from the HdRprim derived
classes to fix the build
Prior to this change, top level subcomponents would be collapsed, hiding
all of its children. Now, nested subcomponents will be found and
included in Expanded representations of scene assemblies
@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Apr 12, 2022

This branch is tracking https://github.com/dj-mcg/maya-usd/tree/pr/Pass_RenderTag_To_Common_Sync_Fn in order to build. Please let me know if you'd prefer I re-submit this branch once the build failure is addressed

@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Apr 29, 2022

Hey folks, please let me know if I need to resubmit this PR, thanks so much!

@dj-mcg
Copy link
Collaborator Author

dj-mcg commented May 2, 2022

Hi, it looks like some remote builds are failing to launch in pre-flight for some reason. Is this something I need to resolve on my end?

@williamkrick
Copy link
Contributor

Hi, it looks like some remote builds are failing to launch in pre-flight for some reason. Is this something I need to resolve on my end?

No, there is an issue with the preflight system yesterday. I believe it is fixed now so I launched another run.

williamkrick
williamkrick previously approved these changes May 3, 2022
// Get the exclude ancestor's proxy shape node.
SdfPath excludeAncestorPath = entry.first;
SdfPath proxyShapePath = excludeAncestorPath.AppendChild(
TfToken(TfStringPrintf("%sProxy", excludeAncestorPath.GetName().c_str())));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason "Proxy" is not in the local _tokens?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I can add it if you prefer!

@dj-mcg
Copy link
Collaborator Author

dj-mcg commented May 6, 2022

OK I tokenized that "Proxy" suffix, please have another look @williamkrick - thanks!

@williamkrick williamkrick self-requested a review May 8, 2022 12:29
@seando-adsk seando-adsk added pxr Related to Pixar plugin vp2renderdelegate Related to VP2RenderDelegate ready-for-merge Development process is finished, PR is ready for merge labels May 10, 2022
@seando-adsk seando-adsk merged commit d130ad7 into Autodesk:dev May 10, 2022
@dj-mcg dj-mcg deleted the pr/Show_Nested_Subcomponents_in_Expanded_Representation branch May 12, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pxr Related to Pixar plugin ready-for-merge Development process is finished, PR is ready for merge vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants