-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored and simplified AL_USDMaya primvar interpolation type detection #2284
Refactored and simplified AL_USDMaya primvar interpolation type detection #2284
Conversation
@williamkrick Can you have a quick look at this change in the AL plugin. Thanks. |
@J-Mo63 We are having problems with our internal preflight system because of a recent API change on Github. So if this is not urgent can we wait until that is fixed before running the preflight and getting this merged in? Sean |
No worries @seando-adsk! How long do you suspect it will be down for? We have a couple of PRs we'll be sending up over the next week or so. |
@J-Mo63 The problem is a change to the GitHub API. There is a thread about it here: https://github.uint.cloudmunity/t/no-longer-able-to-list-in-progress-builds-via-the-api/244175/4 Sean |
@J-Mo63 The github problem is fixed. I ran the preflight and there was a single test timeout error: Thanks, Sean |
Unfortunately we can't test for Py2/2020 on Windows here, but I would be quite surprised if the changelist on this PR would affect it. I'll check with the team on that though. |
This PR removes several unused primvar interpolation type detection functions from
AL_USDMaya
related toVec3
andVec4
, as well as bolstering the testing performed for UV and colour set interpolation type detection functions. The implementation of the used interpolation type detection methods has been preserved for now due to the ongoing migration effort to the Autodesk plugin. On a side note, these tests historically use a 31-vert, 8-faced shape (one face of 3 points) - keep in mind this is an open shape.