Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored and simplified AL_USDMaya primvar interpolation type detection #2284

Merged
merged 8 commits into from
Apr 19, 2022

Conversation

jonjondev
Copy link
Contributor

This PR removes several unused primvar interpolation type detection functions from AL_USDMaya related to Vec3 and Vec4, as well as bolstering the testing performed for UV and colour set interpolation type detection functions. The implementation of the used interpolation type detection methods has been preserved for now due to the ongoing migration effort to the Autodesk plugin. On a side note, these tests historically use a 31-vert, 8-faced shape (one face of 3 points) - keep in mind this is an open shape.

@seando-adsk
Copy link
Collaborator

@williamkrick Can you have a quick look at this change in the AL plugin. Thanks.

@seando-adsk seando-adsk added the al Related to AnimalLogic plugin label Apr 12, 2022
@seando-adsk
Copy link
Collaborator

@J-Mo63 We are having problems with our internal preflight system because of a recent API change on Github. So if this is not urgent can we wait until that is fixed before running the preflight and getting this merged in?

Sean

@jonjondev
Copy link
Contributor Author

So if this is not urgent can we wait until that is fixed before running the preflight and getting this merged in?

No worries @seando-adsk! How long do you suspect it will be down for? We have a couple of PRs we'll be sending up over the next week or so.

@seando-adsk
Copy link
Collaborator

@J-Mo63 The problem is a change to the GitHub API. There is a thread about it here: https://github.uint.cloudmunity/t/no-longer-able-to-list-in-progress-builds-via-the-api/244175/4
Unfortunately I have no time frame on when it will be fixed.

Sean

@seando-adsk
Copy link
Collaborator

@J-Mo63 The github problem is fixed. I ran the preflight and there was a single test timeout error:
157/157 Test #171: GTest:AL_USDTransactionTests ....................***Timeout 500.02 sec
I don't think that was affected by your changes. Can you confirm?

Thanks, Sean

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Apr 19, 2022
@seando-adsk seando-adsk merged commit 25ca3a0 into Autodesk:dev Apr 19, 2022
@jonjondev
Copy link
Contributor Author

@J-Mo63 The github problem is fixed. I ran the preflight and there was a single test timeout error: 157/157 Test #171: GTest:AL_USDTransactionTests ....................***Timeout 500.02 sec I don't think that was affected by your changes. Can you confirm?

Thanks, Sean

Unfortunately we can't test for Py2/2020 on Windows here, but I would be quite surprised if the changelist on this PR would affect it. I'll check with the team on that though.

@jonjondev jonjondev deleted the J-Mo63/refactor-primvar-diff branch April 20, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
al Related to AnimalLogic plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants