-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mesh export options to preserve and remap UV set names #2283
Added mesh export options to preserve and remap UV set names #2283
Conversation
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
c40b81f
to
135b048
Compare
914f180
to
735c280
Compare
Hey @seando-adsk, looks like preflight is passing. Any chance this can get a review? |
@J-Mo63 Sorry about the delay. I've assigned a reviewer now. |
lib/mayaUsd/commands/Readme.md
Outdated
@@ -153,6 +154,7 @@ their own purposes, similar to the Alembic export chaser example. | |||
| `-materialsScopeName` | `-msn` | string | `Looks` | Materials Scope Name | | |||
| `-mergeTransformAndShape` | `-mt` | bool | true | Combine Maya transform and shape into a single USD prim that has transform and geometry, for all "geometric primitives" (gprims). This results in smaller and faster scenes. Gprims will be "unpacked" back into transform and shape nodes when imported into Maya from USD. | | |||
| `-normalizeNurbs` | `-nnu` | bool | false | When setm the UV coordinates of nurbs are normalized to be between zero and one. | | |||
| `-preserveUVSetNames` | `-puv` | bool | false | Refrain from renaming UV sets additional to "map1" to "st1", "st2", etc; "map1" will always be renamed to "st". | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment may be improved:
- In the code, -remapUVSetsTo takes priority over -preserveUVSetNames. We need to add a comment here clarifying this behaviour.
- The comment here says: "map1" will always be renamed to "st". I'm not sure I saw this behaviour in the code. Is this true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sorry that's a bit outdated. I'll go ahead and fix that right up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice feature. Thanks, @J-Mo63.
I request only a couple minor improvements. Please see in the comments.
Hey @vlasovi, your feedback has been actioned. Let me know if it's all good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Currently, the ADSK plugin always authors UV sets as
st
,st1
,st2
, etc. While AL's pipeline ultimately assumes thatmap1
should be renamed tost
on export and additional named sets should retain their naming as specified in Maya.A new export option,
-preserveUVSetNames
(-puv
), has been added to allow for the preservation of set names:A second export option,
-remapUVSetsTo
(-ruv
), has been added on top of this to provide a generalised solution to our specific use-case, where the optionsremapUVSetsTo=[[map1, st], [rigging_utility, my_uv_set]]
would produce: