Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-122640 fix crash with deactivate and console #2268

Merged
merged 5 commits into from
Apr 14, 2022

Conversation

pierrebai-adsk
Copy link
Collaborator

Fix a crash that happened when a prim was deactivated in the outliner while the MEL console was docked and MEl history options "show all commands" was on. It was due to recursive paint event corrupting the Qt internal paint engine.

Fix a crash that happened when a prim was deactivated in the outliner while the MEL console was docked and MEl history options "show all commands" was on. It was due to recursive paint event corrupting the Qt internal paint engine.
The displayRGBColor can fail or fail to return a valid color. It actually happens in the unit tests...
So retry to initialize the color until it works.
@pierrebai-adsk
Copy link
Collaborator Author

Only PF failure is the OSX master, which failed because the build failed to start. (Second times this happens today, the server seems flaky.)

Add a callback to update the invisible color whne the color prefs change.
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the other changes. Just a couple of minor feedback now.

@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Apr 13, 2022
@pierrebai-adsk
Copy link
Collaborator Author

Manual PF passed except for the known Linux interactive image comparison due to the Maya default light intensity changes.

Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a check that appears to be funky, but otherwise LGTM. Actually, if the check always passes, wonder why it's there in the first place?

@seando-adsk seando-adsk added the ufe-usd Related to UFE-USD plugin in Maya-Usd label Apr 14, 2022
@seando-adsk seando-adsk merged commit 5f6a387 into dev Apr 14, 2022
@seando-adsk seando-adsk deleted the t_bailp/MAYA-122640/deactivate-crash branch April 14, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants