-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-122640 fix crash with deactivate and console #2268
Conversation
Fix a crash that happened when a prim was deactivated in the outliner while the MEL console was docked and MEl history options "show all commands" was on. It was due to recursive paint event corrupting the Qt internal paint engine.
The displayRGBColor can fail or fail to return a valid color. It actually happens in the unit tests... So retry to initialize the color until it works.
Only PF failure is the OSX master, which failed because the build failed to start. (Second times this happens today, the server seems flaky.) |
Add a callback to update the invisible color whne the color prefs change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the other changes. Just a couple of minor feedback now.
Manual PF passed except for the known Linux interactive image comparison due to the Maya default light intensity changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a check that appears to be funky, but otherwise LGTM. Actually, if the check always passes, wonder why it's there in the first place?
Fix a crash that happened when a prim was deactivated in the outliner while the MEL console was docked and MEl history options "show all commands" was on. It was due to recursive paint event corrupting the Qt internal paint engine.