Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya-121344 - Points schema support in HdVP2 render delegate #2190

Merged
merged 46 commits into from
Apr 6, 2022

Conversation

vlasovi
Copy link
Collaborator

@vlasovi vlasovi commented Mar 16, 2022

No description provided.

vlasovi and others added 30 commits February 3, 2022 14:36
# Conflicts:
#	lib/mayaUsd/render/vp2RenderDelegate/mesh.cpp
MAYA-109380 - Create a common parent class for HdVP2BasisCurves, HdVP2Mesh and future VP2 shapes
@vlasovi
Copy link
Collaborator Author

vlasovi commented Mar 17, 2022

The unreviewed code starts from [fdcfcff] [Fixing a crash related to the new requirement of MaterialX to support…]

@seando-adsk
Copy link
Collaborator

@vlasovi Is this PR correct? There are 46 commits. Maybe we can clean it up a bit and squash some of them together?

@vlasovi
Copy link
Collaborator Author

vlasovi commented Mar 17, 2022

@seando-adsk I would prefer not to squash any commits. A lot of them are refactoring and I'd like to be able to switch to particular commits in case of a regression.

@vlasovi vlasovi added the do-not-merge-yet Development is not finished, PR not ready for merge label Mar 17, 2022
@seando-adsk
Copy link
Collaborator

@vlasovi Is there a reason for the "do not merge" label? It seems this PR is ready.

@vlasovi
Copy link
Collaborator Author

vlasovi commented Apr 6, 2022

@seando-adsk if the dev branch is reopen for PRs, this one can be merged

@seando-adsk
Copy link
Collaborator

@vlasovi Thanks. Sorry I just noticed there are "security/flawfinder" being reported. Can you have a look at these and either fix or dismiss them (if not relevant).

@vlasovi
Copy link
Collaborator Author

vlasovi commented Apr 6, 2022

@seando-adsk I cleared the issues as they are not relevant

@seando-adsk seando-adsk added the vp2renderdelegate Related to VP2RenderDelegate label Apr 6, 2022
@seando-adsk seando-adsk merged commit 1eac3ec into dev Apr 6, 2022
@seando-adsk seando-adsk deleted the vlasovi/MAYA-121344 branch April 6, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge-yet Development is not finished, PR not ready for merge vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants