-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya-121344 - Points schema support in HdVP2 render delegate #2190
Conversation
…me are moved to MayaUsdRPrim.
… shared code in there
# Conflicts: # lib/mayaUsd/render/vp2RenderDelegate/mesh.cpp
… to prepare it for merging
MAYA-109380 - Create a common parent class for HdVP2BasisCurves, HdVP2Mesh and future VP2 shapes
# Conflicts: # lib/mayaUsd/render/vp2RenderDelegate/material.h # lib/mayaUsd/render/vp2RenderDelegate/mesh.cpp # lib/mayaUsd/render/vp2RenderDelegate/mesh.h
… tangetnt buffer.
…hared code in there
…th one templated function to shorten up the code
The unreviewed code starts from [fdcfcff] [Fixing a crash related to the new requirement of MaterialX to support…] |
@vlasovi Is this PR correct? There are 46 commits. Maybe we can clean it up a bit and squash some of them together? |
@seando-adsk I would prefer not to squash any commits. A lot of them are refactoring and I'd like to be able to switch to particular commits in case of a regression. |
@vlasovi Is there a reason for the "do not merge" label? It seems this PR is ready. |
@seando-adsk if the dev branch is reopen for PRs, this one can be merged |
@vlasovi Thanks. Sorry I just noticed there are "security/flawfinder" being reported. Can you have a look at these and either fix or dismiss them (if not relevant). |
@seando-adsk I cleared the issues as they are not relevant |
No description provided.