MAYA-122014 support duplicate to Maya to non root #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Mar 7, 2022
- Add isMayaRootPath helper function.
- Use the destination path when duplicating as Maya.
- Add a unit test.
- Add isMayaRootPath helper function. - Use the destination path when duplicating as Maya. - Add a unit test.
|
The only PF failure is the Linux interactive on GPU which is currently known to fail due to image comparison. |
ppt-adsk
requested changes
Mar 8, 2022
lib/mayaUsd/ufe/Utils.cpp
Outdated
| @@ -372,6 +372,21 @@ MDagPath ufeToDagPath(const Ufe::Path& ufePath) | |||
| ); | |||
| } | |||
|
|
|||
| bool isMayaRootPath(const Ufe::Path& ufePath) | |||
There was a problem hiding this comment.
Could be simply
return (ufePath.runTimeId() == g_MayaRtid) && (ufePath.size() == 1);
lib/mayaUsd/ufe/Utils.h
Outdated
| @@ -125,6 +125,10 @@ Ufe::PathSegment dagPathToPathSegment(const MDagPath& dagPath); | |||
| MAYAUSD_CORE_PUBLIC | |||
| MDagPath ufeToDagPath(const Ufe::Path& ufePath); | |||
|
|
|||
| //! Verify if the UFE path is the Maya root. | |||
There was a problem hiding this comment.
Hmmm, wonder about the name. In Maya the root node is called world, and it's called that way in Maya commands and documentation as well. Perhaps call it isMayaWorldPath()?
| self.assertEqual(1, len(xformNames)) | ||
| xformName = xformNames[0] | ||
|
|
||
| # Duplicate USD data as Maya data, placing it under the root. |
- Name of the function. - Comments in the test.
ppt-adsk
approved these changes
Mar 8, 2022
|
Again, image diff on linux error. We can ignore, unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.