Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-121937 - Renaming 2 prims w/illegal chars will crash Maya #2151

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

seando-adsk
Copy link
Collaborator

MAYA-121937 - Renaming 2 usd items with illegal characters will cause Maya to crash

  • Validate the name before making it unique.

* Validate the name before making it unique.
@ppt-adsk
Copy link
Collaborator

ppt-adsk commented Mar 1, 2022

Can we add the crash repro steps to the automated test for this?

@seando-adsk
Copy link
Collaborator Author

@ppt-adsk Ah yes good idea. I'll add a test.

@pierrebai-adsk
Copy link
Collaborator

Good catch on the other cases of the same bug.

pierrebai-adsk
pierrebai-adsk previously approved these changes Mar 1, 2022
* Added test case for crash (fixed now).
@seando-adsk seando-adsk added ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd labels Mar 2, 2022
@seando-adsk seando-adsk merged commit 61f4731 into dev Mar 2, 2022
@seando-adsk seando-adsk deleted the donnels/MAYA-121937/validate_name_first branch March 2, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants