MAYA-121625: cache to USD: take out 'Parent Scope' from options #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Used patter for sub-option to remove the Parent Scope field from the Cache To Usd.
ppt-adsk
previously approved these changes
Feb 18, 2022
seando-adsk
commented
Feb 18, 2022
| @@ -181,7 +184,7 @@ def fileOptionsTabPage(tabLayout): | |||
| # USD file option controls will be parented under this layout. | |||
| # resultCallback not called on "post", is therefore an empty string. | |||
| fileOptionsScroll = cmds.columnLayout('fileOptionsScroll') | |||
| mel.eval('mayaUsdTranslatorExport("fileOptionsScroll", "post=all;!animation-data", "' + getCacheExportOptions() + '", "")') | |||
| mel.eval('mayaUsdTranslatorExport("fileOptionsScroll", "post={exportOpts}", "{cacheOpts}", "")'.format(exportOpts=kTranslatorExportOptions, cacheOpts=getCacheExportOptions())) | |||
There was a problem hiding this comment.
Used constant so we have same string for both post and query.
| @@ -34,6 +34,9 @@ | |||
| # Cache options in string format, for MEL mayaUsdTranslatorExport() consumption. | |||
| _cacheExportOptions = None | |||
|
|
|||
| # The options string that we pass to mayaUsdTranslatorExport. | |||
| kTranslatorExportOptions = 'all;!output-parentscope;!animation-data' | |||
There was a problem hiding this comment.
Created constant for this string (used in 2 places) and added new string "output-parentscope"
| @@ -241,7 +244,7 @@ def cacheCommitUi(parent, selectedFile): | |||
|
|
|||
| # The following call will set _cacheExportOptions. Initial settings not | |||
| # accessed on "query", is therefore an empty string. | |||
| mel.eval('mayaUsdTranslatorExport("fileOptionsScroll", "query", "", "mayaUsdCacheMayaReference_setCacheOptions")') | |||
| mel.eval('mayaUsdTranslatorExport("fileOptionsScroll", "query={exportOpts}", "", "mayaUsdCacheMayaReference_setCacheOptions")'.format(exportOpts=kTranslatorExportOptions)) | |||
There was a problem hiding this comment.
Need the same option string for the query so you don't get back those options (like parent scope).
Comment on lines
+165
to
+167
| register("kExportParentScopeAnn", "Name of the USD scope that is the parent of the exported data."); | ||
| register("kExportParentScopeLbl", "Create USD Parent Scope:"); | ||
| register("kExportParentScopePht", "USD Prim Name"); |
There was a problem hiding this comment.
Fixed typo in name
Comment on lines
+539
to
+544
| if (stringArrayContains("output-parentscope", $sectionNames)) { | ||
| separator -style "none"; | ||
|
|
||
| textFieldGrp -l `getMayaUsdString("kExportParentScopLbl")` -placeholderText `getMayaUsdString("kExportParentScopPht")` | ||
| -annotation `getMayaUsdString("kExportParentScopAnn")` parentScopeField; | ||
| textFieldGrp -l `getMayaUsdString("kExportParentScopeLbl")` -placeholderText `getMayaUsdString("kExportParentScopePht")` | ||
| -annotation `getMayaUsdString("kExportParentScopeAnn")` parentScopeField; | ||
| } |
There was a problem hiding this comment.
Added ability to not add this parent scope field.
ppt-adsk
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-121625: cache to USD: take out 'Parent Scope' from options