Implement ufe attribute notify dev #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Jan 15, 2020
seando-adsk
reviewed
Jan 16, 2020
seando-adsk
approved these changes
Jan 16, 2020
mattyjams
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
This generally seems ok to me.
I had some concerns about the lack of thread safety in AttributeChangedNotificationGuard and its potential to bite us in the future, but I'll let you be the judge of whether that warrants attention now. And I still can't explain the multiple notice mystery for sequential UsdAttribute::Set() calls, but it sounds like aggregating those is what we want to do here anyway.
mattyjams
reviewed
Jan 31, 2020
|
Thanks Matt for the review! |
kxl-adsk
suggested changes
Feb 2, 2020
kxl-adsk
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.