MAYA-115117 Deactivate prim on pull instead of using exclude feature #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxl-adsk
commented
Jan 27, 2022
| @@ -46,8 +46,7 @@ namespace { | |||
|
|
|||
| // We want to display the unloaded prims, so removed UsdPrimIsLoaded from | |||
| // the default UsdPrimDefaultPredicate. | |||
| const Usd_PrimFlagsConjunction MayaUsdPrimDefaultPredicate | |||
| = UsdPrimIsActive && UsdPrimIsDefined && !UsdPrimIsAbstract; | |||
| const Usd_PrimFlagsConjunction MayaUsdPrimDefaultPredicate = UsdPrimIsDefined && !UsdPrimIsAbstract; | |||
There was a problem hiding this comment.
I wish the predicate in USD be more flexible!
| @@ -98,7 +98,8 @@ class MAYAUSD_CORE_PUBLIC ProxyShapeHierarchy : public Ufe::Hierarchy | |||
|
|
|||
| private: | |||
| const PXR_NS::UsdPrim& getUsdRootPrim() const; | |||
| Ufe::SceneItemList createUFEChildList(const PXR_NS::UsdPrimSiblingRange& range) const; | |||
| Ufe::SceneItemList | |||
| createUFEChildList(const PXR_NS::UsdPrimSiblingRange& range, bool filterInactive) const; | |||
There was a problem hiding this comment.
Negative boolean tend to be confusing. I would prefere this to be filter with true meaning do filter, false meaning do not filter.
There was a problem hiding this comment.
Oh, it mean filter-the-inactive-nodes and not make-filter-inactive... I mis-read the meaning of the variable.
pierrebai-adsk
approved these changes
Jan 27, 2022
ppt-adsk
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude prim is way too expensive for complex scenes since it repopulates the entire render index. We decided to switch to deactivation which reduces the cost to what changed.