-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vertex colour utility node and translation for USD preview surface #2016
Added vertex colour utility node and translation for USD preview surface #2016
Conversation
2a50db4
to
c087d76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and covers the most frequent use case. Thanks!
The unit tests fail because |
Ah! Thanks for that. I'd been trying to figure out why it couldn't find any panels. |
c087d76
to
cde28d5
Compare
cde28d5
to
351dd61
Compare
This PR adds vertex colour functionality to the USD preview surface shader by adding a
cpvColor
utility node and implementing its connection as part of the USD translation of thedisplayColor
primvar reader. While initial implementations utilised theMPxShaderOverride
to adddisplayColor
as a feature of the USD preview surface node itself, we eventually landed on adding it as a separate utility node, so that it could more closely mimick USD shade's functionality, and provide greater flexibility.The images below demonstrate it in action (left is lambert shading, middle is preview surface shading, right is proxy shape):