[pxr] when loading the pixar plugin, trigger an immediate fail #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elrond79 FYI. We will wait for #154 to be merged first to avoid conflicts that would force us to revalidate & retest much bigger PR. |
|
@elrond79 Please resolve conflicts. |
added 2 commits
January 20, 2020 14:37
...if we find an operation failed, instead of printing a warning and continuing
now that CMAKE_INSTALL_PREFIX is not altered, don't need to go up two levels to find plugin/pxr
3571771 to
34fe8c3
Compare
|
Done... |
kxl-adsk
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...if we find an operation failed, instead of printing a warning and continuing
I originally added this because to catch an error on an internal luma branch, but it has also exposed an error in the AL test TestPxrUsdTranslators (fixed in 2c78161)