Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-114979 - Validate normal maps for correctness #1918

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

JGamache-autodesk
Copy link
Collaborator

Also check monochromatic inputs.

Connecting a file texture node interactively or by script will
automatically set the color attributes on the file node according to the
destination of the connection.

@dgovil : Added an env var for automatic fixups on load.

Second PR for issue #1834

Also check monochromatic inputs.

Connecting a file texture node interactively or by script will
automatically set the color attributes on the file node according to the
destination of the connection.

Added an env var for automatic fixups on load.

Second PR for issue #1834
@dgovil
Copy link
Collaborator

dgovil commented Dec 16, 2021

Thanks for tagging me to keep me in the loop.

I like the setup you've created for this. That env var will be very useful.

@JGamache-autodesk JGamache-autodesk added the import-export Related to Import and/or Export label Dec 16, 2021
Copy link
Contributor

@boudrey boudrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JGamache-autodesk JGamache-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Dec 17, 2021
@seando-adsk seando-adsk merged commit c4d5df9 into dev Dec 17, 2021
@seando-adsk seando-adsk deleted the t_gamaj/MAYA-114979/adjust_normal_texture branch December 17, 2021 14:54
@dgovil
Copy link
Collaborator

dgovil commented Dec 20, 2021

@JGamache-autodesk One point that had come up internally is that perhaps this should respect the ignoreColorSpaceFileRules setting in Maya to allow for manual control in those scenarios.

We can put in a PR if you like, but just wanted to get your thoughts first?

@JGamache-autodesk
Copy link
Collaborator Author

@dgovil setting ignoreColorSpaceFileRules makes a lot of sense, otherwise a change at the global level will flip the settings. If you have a PR ready please post it. Thanks!

@dgovil
Copy link
Collaborator

dgovil commented Dec 21, 2021

Cool, I'll prepare a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants