Unnest UV reader and optimize #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The UsdUVTexture and UsdTransform2d are no longer nested under the file node - Shared place2dTexture nodes result in shared UsdUVTexture - If a file node does not have a place2DTexture node, then is shares a common UsdUVTexture
boudrey
reviewed
Dec 16, 2021
| @@ -77,7 +78,7 @@ TF_DEFINE_PRIVATE_TOKENS( | |||
| _tokens, | |||
|
|
|||
| // UsdPrimvarReader_float2 Prim Name | |||
| ((PrimvarReaderShaderName, "TexCoordReader")) | |||
| ((PrimvarReaderShaderName, "shared_TexCoordReader")) | |||
There was a problem hiding this comment.
Could changing this name affects loading of existing files?
There was a problem hiding this comment.
No. The name of the place2dTexture node is not restored when importing (and it was not previously written, as you can see).
boudrey
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First item in to fix in Issue #1834
file node
common UsdUVTexture
More to follow.