Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-113409 - Adjust unit tests for UFE 3.0 #1888

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

JGamache-autodesk
Copy link
Collaborator

No description provided.

@JGamache-autodesk JGamache-autodesk added do-not-merge-yet Development is not finished, PR not ready for merge ufe Related to UFE component in Maya labels Dec 7, 2021
@@ -394,6 +394,7 @@ def createCommonAPI(testCase, sphereXformable):

self.runTestOpUndo(createCommonAPI, 'xformOp:translate')

@unittest.skipUnless(ufeUtils.ufeFeatureSetVersion() < 3, 'Creating a SceneItem was fixed in UFE v3.14')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should test explicitly for UFE 0.3.14, using UFE_PREVIEW_VERSION_NUM, as external builders of maya-usd don't have that UFE version yet. See e.g. testAttribute.py for details.

@JGamache-autodesk JGamache-autodesk removed the do-not-merge-yet Development is not finished, PR not ready for merge label Dec 7, 2021
@JGamache-autodesk
Copy link
Collaborator Author

Only one test failure on the known testVP2RenderDelegateIsolateSelect issue.

@JGamache-autodesk JGamache-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Dec 7, 2021
@kxl-adsk kxl-adsk merged commit e2e73fc into dev Dec 7, 2021
@kxl-adsk kxl-adsk deleted the t_gamaj/MAYA-113409/fix_unit_tests branch December 7, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge ufe Related to UFE component in Maya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants