Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-113820: [Github 1543] Unloaded prims should appear in the outliner #1877

Merged

Conversation

seando-adsk
Copy link
Collaborator

MAYA-113820: [Github 1543] Unloaded prims should appear in the outliner

  • In default prim predicate remove IsLoaded (so we will always display both loaded and unloaded prims).

* In default prim predicate remove IsLoaded (so we will
  always display both loaded and unloaded prims).
@seando-adsk seando-adsk added the ufe-usd Related to UFE-USD plugin in Maya-Usd label Dec 3, 2021
@seando-adsk seando-adsk requested a review from kxl-adsk December 3, 2021 15:46
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Needs a test :)
  2. Great stuff, but there is also the UsdPrimDefaultPredicate in ProxyShapeHierarchy.cpp. At some point we should take the time to factor out common code from both these classes...

* Forgot the ProxyShapeHierarchy and added test.
@seando-adsk seando-adsk requested review from ppt-adsk and removed request for kxl-adsk December 3, 2021 19:13
@seando-adsk
Copy link
Collaborator Author

Right thanks for catching the ProxyShapeHierarchy. I didn't do any code refactoring yet. Let's do that separately.
I've added a test for the unload to verify children count.

@ppt-adsk
Copy link
Collaborator

ppt-adsk commented Dec 3, 2021

I didn't do any code refactoring yet. Let's do that separately.
Absolutely, it's out of scope for this pull request. Thanks for the fix!

ppt-adsk
ppt-adsk previously approved these changes Dec 3, 2021
@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Dec 6, 2021
@kxl-adsk kxl-adsk merged commit 28a6a26 into dev Dec 6, 2021
@kxl-adsk kxl-adsk deleted the donnels/MAYA-113820/unloaded_prims_should_appear_the_outliner branch December 6, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants