Added multi-format serialisation test for shared LayerManager

[jonjondev]

As requested by @kxl-adsk in PR #1792 (comment), I've gone ahead and added a test for the updated LayerManager to test multi-format serialisation, similar to the one added here.

[jonjondev]

Hey @kxl-adsk, looks the test is just having some issues in Windows. I can't exactly test on my end, but do you know why there might be a permissions issue during cleanup?

======================================================================
    ERROR: testMultipleFormatsSerialisation (testLayerManagerSerialization.testLayerManagerSerialization)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "S:\jenkins\workspace\ecg-mayausd-branch-preflight-2022-python3-windows\ecg-maya-usd\maya-usd\test\lib\mayaUsd\nodes\testLayerManagerSerialization.py", line 357, in testMultipleFormatsSerialisation
        shutil.rmtree(self._currentTestDir)
      File "P:\shared\Artifactory\Windows\rundev-2022\202112010615\runtime\2daf616\runTime\Python37\lib\shutil.py", line 516, in rmtree
        return _rmtree_unsafe(path, onerror)
      File "P:\shared\Artifactory\Windows\rundev-2022\202112010615\runtime\2daf616\runTime\Python37\lib\shutil.py", line 400, in _rmtree_unsafe
        onerror(os.unlink, fullname, sys.exc_info())
      File "P:\shared\Artifactory\Windows\rundev-2022\202112010615\runtime\2daf616\runTime\Python37\lib\shutil.py", line 398, in _rmtree_unsafe
        os.unlink(fullname)
    PermissionError: [WinError 5] Access is denied: 'C:\\Temp\\LayerManagerTest1mrfl5b6\\TestLayer.usd'

[kxl-adsk]

Test is trying to write to a folder it doesn’t have permission in our Jenkins environment. This is why we recommend tests to write to the build folder as per earlier conversation.

[jonjondev]

Test is trying to write to a folder it doesn’t have permission in our Jenkins environment. This is why we recommend tests to write to the build folder as per earlier conversation.

And in this scenario it's already been cd'd into the build directory or is there a path variable that will get me there? Our test system does not make a distinction between source and build so it's hard to understand what's going on in the PF.

[seando-adsk]

I'm not sure why this new test is having a problem removing the folder it created for the new test. I see other uses of rmtree in this test and those are working. What I would suggest trying is using the env var MAYA_APP_DIR that is set for each test here: https://github.com/Autodesk/maya-usd/blob/dev/cmake/test.cmake#L341. Each test gets its own temporary folder (in the build folder).

[jonjondev]

Thanks for the tip @seando-adsk! I think I figured it out, however there now seems to be a (probably unrelated) issue with another test, but only on MayaUsd - Maya Master [USD max, Python 3, Interactive] (Linux):

======================================================================
FAIL: testInstancedIsolateSelect (__main__.testVP2RenderDelegateIsolateSelect)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/S/jenkins/workspace/ecg-mayausd-branch-preflight-cotd-python3-pxrusd-max-interactive-linux/ecg-maya-usd/maya-usd/test/lib/mayaUsd/render/vp2RenderDelegate/testVP2RenderDelegateIsolateSelect.py", line 248, in testInstancedIsolateSelect
    self.assertSnapshotClose('autoLoadSelected_instance_stage.png')
  File "/home/S/jenkins/workspace/ecg-mayausd-branch-preflight-cotd-python3-pxrusd-max-interactive-linux/ecg-maya-usd/maya-usd/test/lib/mayaUsd/render/vp2RenderDelegate/testVP2RenderDelegateIsolateSelect.py", line 64, in assertSnapshotClose
    retVal = self.assertImagesClose(baselineImage, snapshotImage)
  File "/home/S/jenkins/workspace/ecg-mayausd-branch-preflight-cotd-python3-pxrusd-max-interactive-linux/ecg-maya-usd/maya-usd/test/testUtils/imageUtils.py", line 193, in assertImagesClose
    self.fail(msg)
AssertionError: Images differed by 0.041357334407528444 (max allowed: 0.0001):
  /home/S/jenkins/workspace/ecg-mayausd-branch-preflight-cotd-python3-pxrusd-max-interactive-linux/ecg-maya-usd/maya-usd/test/lib/mayaUsd/render/vp2RenderDelegate/VP2RenderDelegateIsolateSelectTest/baseline/autoLoadSelected_instance_stage.png
  /home/S/jenkins/workspace/ecg-mayausd-branch-preflight-cotd-python3-pxrusd-max-interactive-linux/build/RelWithDebInfo/test/lib/mayaUsd/render/vp2RenderDelegate/testVP2RenderDelegateIsolateSelectOutput/autoLoadSelected_instance_stage.png

Please let me know if you think it's related to the added test or not.

[kxl-adsk]

Indeed. It looks unrelated. Let’s merge this one.