Use HdRprim's render tag data for VP2 mesh shared data #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in USD 22.02, Hydra internally manages render tag data for rprims. This was causing the dirty bit to be cleared prior to calling sync, causing the render tag data to never get set in _meshSharedData. Ultimately we could always just use the rprim's GetRenderTag API, but since MeshViewportCompute is only sent the SharedData strcuture, we'll set _meshSharedData unconditionally for now.
williamkrick
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in USD 22.02, Hydra internally manages render tag data for
rprims. This was causing the dirty bit to be cleared prior to calling
sync, causing the render tag data to never get set in _meshSharedData.
Ultimately we could always just use the rprim's GetRenderTag API, but
since MeshViewportCompute is only sent the SharedData strcuture, we'll
set _meshSharedData unconditionally for now.