Boudrey/maya 113462/wrapshader #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation for python binding for Shader Reader/Writer.
…tions are not Python friendly so a refactor is required for support.
+ clang-format fixes
…ation and creation functions without doing too much wizardry.
Adding missing last CRLF at end of file. Adding CanImport(...) in testShaderReader
JGamache-autodesk
requested changes
Oct 7, 2021
| boost::python::object cl, | ||
| const TfToken& usdShaderId, | ||
| const TfToken& mayaNodeTypeName, | ||
| const TfToken& materialConversion) |
There was a problem hiding this comment.
Looks like you took the register function signature of UsdMayaSymmetricShaderReader::Register(). The default Register function found in UsdMayaShaderReaderRegistry only requires usdInfoId.
The mayaNodeTypeName and materialConversion are known by the implementation of the reader and does not need to be provided on registration.
| boost::python::object cl, | ||
| const TfToken& mayaNodeTypeName, | ||
| const TfToken& usdShaderId, | ||
| const TfToken& materialConversionName) |
There was a problem hiding this comment.
Same thing here. This looks like the signature of UsdMayaSymmetricShaderWriter::Register() when we want UsdMayaShaderWriterRegistry::Register()
Linux build fix. MaterialX reader available only in recent Maya versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.