MAYA-113944 Enable primvar filtering to match HdSt behavior. #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamkrick
commented
Sep 30, 2021
| @@ -127,6 +127,8 @@ class HdVP2RenderDelegate final : public HdRenderDelegate | |||
| TfTokenVector GetMaterialRenderContexts() const override; | |||
| #endif | |||
|
|
|||
| bool IsPrimvarFilteringNeeded() const override { return true; } | |||
There was a problem hiding this comment.
This flag is tested in gprimAdapter to determine if all primvars are necessary. When the flag is not set _ComputeAndMergePrimvar is called on every primvar on the rprim. When the flag is set _ComputeAndMergePrimvar is only called for primvars actually used by the usd material on the gprim.
When we execute this code with Vp2RenderDelegate the materialUsdPath is empty, and no primvars are updated. That is fine because our mesh adapter will trigger the necessary primvar updates itself.
|
After this change to filtering the performance of the animated scene improves and the next bottleneck is normal calculation performance. |
kxl-adsk
approved these changes
Sep 30, 2021
JGamache-autodesk
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a substantial performance improvement by avoiding calls to _ComputeAndMergePrimvar made from UsdImagingGprimAdapter::UpdateForTime.