Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added USD pick mode fixes for VP2 #1731

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

jonjondev
Copy link
Contributor

This PR adds support for pick mode settings in VP2 to toggle selection level between models, prims, and instances.

@kxl-adsk
Copy link

kxl-adsk commented Oct 1, 2021

We already have a selection by kind available in VP2RenderDelegate and in the UI
Screen Shot 2021-10-01 at 1 45 11 PM

The code responsible for this is in

prim = GetPrimOrAncestorWithKind(prim, selectionKind);

We hope you can adopt this workflow or let us know what's missing.

@jonjondev
Copy link
Contributor Author

Hi @kxl-adsk, thanks for taking a look!

At the moment, the AL team is in the process of realigning our internal changes with this repo, and we want to preserve the history of the original committers where possible. This means that some of the changes being PR'd now will likely be overwritten by later changes as soon as these get merged.

Let me know if that's ok, but yes, we absolutely aim to share as much code as feasible with the ADSK plugin to smooth that migration process later down the road.

Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @J-Mo63, for some reason I thought this change was done in VP2RenderDelegate. I'm starting PF and once passed it should be good to go.

@kxl-adsk kxl-adsk added the al Related to AnimalLogic plugin label Oct 14, 2021
@kxl-adsk kxl-adsk merged commit 4597958 into Autodesk:dev Oct 15, 2021
@jonjondev jonjondev deleted the J-Mo63/added-vp2-pick-mode-fixes branch October 17, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
al Related to AnimalLogic plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants