Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in missing export translator implementation #1728

Conversation

csyshing
Copy link
Collaborator

Python translator export never worked properly, but the mismatch between the wrapping and the Python implementation is causing errors that we would like to eliminate as a potential source of problems.

Where no export is supported, canExport() and exportObject() methods are not expected to be implemented in Python translators - leaving dummy methods which don't return the corret type will cause errors.

If implementing the method but return the incorrect type, you will get a runtime error like this:

TF_PYTHON_EXCEPTION: in TfPyConvertPythonExceptionToTfErrors at line 114 of ../pxr/base/lib/tf/pyError.cpp -- Tf Python Exception
TypeError: No registered converter was able to produce a C++ rvalue of type AL::usdmaya::fileio::translators::ExportFlag from this Python object of type bool

@csyshing csyshing added the al Related to AnimalLogic plugin label Sep 27, 2021
@csyshing
Copy link
Collaborator Author

The unit test failed for the same reason as #1726 and #1727 on Windows + Maya 2019, seems like a problem on the Jenkins machine? Any idea?

@seando-adsk
Copy link
Collaborator

I'll have a look at the failing build. Yesterday we updated all builds to use USD v21.08.

@kxl-adsk kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Sep 29, 2021
@seando-adsk seando-adsk merged commit 7a6e0d7 into Autodesk:dev Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
al Related to AnimalLogic plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants