MAYA-109415 Fix warning on blendShape export #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got "Unrecognized node" error on blendShape export. The node was the fCurve driving the weight. Looked in mayaFindOrigMeshFromBlendShapeTarget() and found out that the traversal would start on a random plug in the checked branch. Sometimes the input geom would be found first, sometimes the fCurve would be traversed as well. Fixed the code to make sure the traversal starts at the inputGeom plug that would have been used to compute fnGeoFilter.inputShapeAtIndex(...) in the ignoreWarning branch.
|
@ysiewappl , since you wrote the original code, I would appreciate if you could have a look. Thanks! |
Yea, I think your fix of starting right from the corresponding element plug for |
ysiewappl
approved these changes
Sep 3, 2021
boudrey
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got "Unrecognized node" error on blendShape export. The node was the
fCurve driving the weight.
Looked in mayaFindOrigMeshFromBlendShapeTarget() and found out that the
traversal would start on a random plug in the checked branch. Sometimes
the input geom would be found first, sometimes the fCurve would be
traversed as well.
Fixed the code to make sure the traversal starts at the inputGeom plug
that would have been used to compute fnGeoFilter.inputShapeAtIndex(...)
in the ignoreWarning branch.