MAYA-111516 When the instnace count changes we need to update everything related #1398
+52
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the instancer. Set the dirty instancer flag. Where the instancer is dirty, re-extract the instance colors.
added 2 commits
May 6, 2021 15:57
…isplayed which are not working right now.
JGamache-autodesk
approved these changes
May 7, 2021
…er index dirty flag in mesh.
williamkrick
commented
May 7, 2021
| @@ -91,7 +91,8 @@ void HdVP2Instancer::_SyncPrimvars() | |||
| // primvars are dirty. | |||
| HdDirtyBits dirtyBits = changeTracker.GetInstancerDirtyBits(id); | |||
| if (HdChangeTracker::IsAnyPrimvarDirty(dirtyBits, id) | |||
| || HdChangeTracker::IsInstancerDirty(dirtyBits, id)) { | |||
| || HdChangeTracker::IsInstancerDirty(dirtyBits, id) | |||
| || HdChangeTracker::IsInstanceIndexDirty(dirtyBits, id)) { | |||
There was a problem hiding this comment.
The important thing here is down at line 128 we clean the instancer. If the instancer doesn't get cleaned then next time the instancer changes HdChangeTracker::MarkInstancerDirty will detect that the dirty bits are not changing and then not send any update.
williamkrick
commented
May 7, 2021
| if (((rprimDirtyBits & HdChangeTracker::DirtyPrimvar) != 0) | ||
| if (((rprimDirtyBits | ||
| & (HdChangeTracker::DirtyPrimvar | HdChangeTracker::DirtyInstancer | ||
| | HdChangeTracker::DirtyInstanceIndex)) |
There was a problem hiding this comment.
Check the additional dirty bit DirtyInstanceIndex!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the instancer. Set the dirty instancer flag. Where the instancer is dirty, re-extract the instance colors.
This also fixes MAYA-110523