MAYA-111466 Add a VP2RenderDelegate test for basis curves to ensure they draw correctly #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGamache-autodesk
approved these changes
May 5, 2021
JGamache-autodesk
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test images capture the current behavior of MayaUSD, including some known issues like complexity 1, 2, and 3 all draw the same, and complexity 1, 2 and 3 draw flat shaded instead of smooth shaded. I decided to add the tests now so that when those issues are fixed we'll be forced to update the test images at that time. If I leave the tests off then it is possible that when the behavior is fixed we'll forget to enable the tests.