MAYA-109334 - Crash when the token for "Info: id" on a material is ed… #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ited to an invalid or empty value -Add check to see if shader (info:id attr) exists while the attribute change to avoid crash
spinell-adsk
commented
Mar 29, 2021
huidong-chen
suggested changes
Mar 29, 2021
…ited to an invalid or empty value -Add check to see if shader (info:id attr) exists while the attribute change to avoid crash
huidong-chen
approved these changes
Mar 29, 2021
|
There is already a warning displayed coming from UsdMayaDiagnosticDelegate::IssueWarning |
kxl-adsk
suggested changes
Apr 2, 2021
There was a problem hiding this comment.
Following interactive tests are failing with this change (Maya 2022):
57 - testVP2RenderDelegateGeomSubset (Failed)
58 - testVP2RenderDelegatePointInstanceSelection (Failed)
59 - testVP2RenderDelegatePointInstancesPickMode (Failed)
61 - testVP2RenderDelegatePerInstanceInheritedData (Failed)
Please investigate.
…ited to an invalid or empty value -Fix vp2 test
|
@HdC-adsk The condition must be below _ApplyVP2Fixes() otherwise the shading is wrong. |
|
Right. The fix looks good to me. Meanwhile, an alternative is to test bxdfNet instead so that we can run the sanity test before everything, I think it should be better.
|
huidong-chen
approved these changes
Apr 8, 2021
kxl-adsk
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ited to an invalid or empty value
-Add check to see if shader (info:id attr) exists while the attribute change to avoid crash