Don't write fStop when depthOfField is disabled. #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamkrick
suggested changes
Mar 27, 2021
JGamache-autodesk
requested changes
Mar 29, 2021
There was a problem hiding this comment.
Thanks for the fix. I would have expected that at least one of the exported cameras in the unit tests would have a disabled depth of field on export to test that the USD stream ends up having the right values, and it would be nice to have an import test with an fStop of zero to exercise the new behavior fully.
ef424ed to
c2b80c0
Compare
williamkrick
approved these changes
Mar 31, 2021
c2b80c0 to
65930f5
Compare
|
Added the test.. |
JGamache-autodesk
approved these changes
Apr 26, 2021
|
@marsupial please apply clang-format so we can trigger PF for this change. |
65930f5 to
0f40aa9
Compare
|
The two failing MacOS are known issues unrelated to this change. This change is now ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maya has an explicit attribute to enable/disable depth of field, but fStop=0 does that in USD.
Currently USD import/export is a direct translation of the USD fStop attribute, which changes intent/meaning.
TODO: Might be good to export the maya fStop curve in a namespaced custom property for loseless data Maya->USD->Maya.