MAYA-108691 - USD: undoing transform will not update manipulator #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Send UFE Transform3d and AttributeValueChanged in response to USD "prim property path" notif. * Added new test to verify these notifs.
seando-adsk
commented
Mar 19, 2021
lib/mayaUsd/ufe/StagesSubject.cpp
Outdated
Comment on lines
214
to
226
| if (nameToken == UsdGeomTokens->xformOpOrder || UsdGeomXformOp::IsXformOp(nameToken)) { | ||
| auto usdPrimPathStr = changedPath.GetPrimPath().GetString(); | ||
| auto ufePath = stagePath(sender) + Ufe::PathSegment(usdPrimPathStr, g_USDRtid, '/'); | ||
| if (!InTransform3dChange::inTransform3dChange()) { | ||
| Ufe::Transform3d::notify(ufePath); | ||
| } | ||
| #ifdef UFE_V2_FEATURES_AVAILABLE | ||
| if (!inAttributeChangedNotificationGuard()) { | ||
| Ufe::AttributeValueChanged vc(ufePath, changedPath.GetName()); | ||
| Ufe::Attributes::notify(vc); | ||
| } | ||
| #endif | ||
| } |
There was a problem hiding this comment.
As we discussed, make sure to send extra UFE notifs for USD prim property path notifs on xformop.
seando-adsk
commented
Mar 19, 2021
Comment on lines
+844
to
+845
| @unittest.skipUnless(ufeUtils.ufeFeatureSetVersion() >= 2, 'testPrimPropertyPathNotifs only available in UFE v2 or greater.') | ||
| def testPrimPropertyPathNotifs(self): |
There was a problem hiding this comment.
New test to verify that these new are received.
ppt-adsk
reviewed
Mar 19, 2021
lib/mayaUsd/ufe/StagesSubject.cpp
Outdated
| // We need to send some notifs so Maya can update (such as on undo | ||
| // to move the transform manipulator back to original position). | ||
| const TfToken nameToken = changedPath.GetNameToken(); | ||
| auto blah = nameToken.GetString(); |
There was a problem hiding this comment.
That's the technical use of blah, right?
ppt-adsk
approved these changes
Mar 19, 2021
* Only want to send extra notif on xformOpOrder attribute.
ppt-adsk
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-108691 - USD: undoing transform will not update manipulator