Adding support for indexed normals on import #1029 #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is related to the issue: |
|
Thank you @koen-v. I just started the PF and assigned Jerry to review. |
| @@ -120,6 +120,7 @@ TranslatorMeshRead::TranslatorMeshRead( | |||
| // timeInterval or default. | |||
| VtVec3fArray points; | |||
| VtVec3fArray normals; | |||
| TfToken normals_interpolation; | |||
There was a problem hiding this comment.
Very minor, but this snake_case variable does stand out in a sea of camelCase variables. Can you make it normalsInterpolation?
There was a problem hiding this comment.
sorry about that, changed and committed
JGamache-autodesk
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Autodesk, I am re-opening this pull request, I added the test.
Thanks,
Koen