Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-110196 - Multiple ProxyShapes with Same Stage (InStageData) Bug #1228

Merged
merged 4 commits into from
Mar 5, 2021

Conversation

alsoussi
Copy link
Contributor

@alsoussi alsoussi commented Mar 2, 2021

We can have a situation where we have multiple proxy shapes that point to the same exact stage, using the InStageData port. Unfortunately this causes an issue in the layer editor since the combo-box is keeping track of the stage only, so two entries with the same stage is ambiguous. 

The fix was to move away from storing the Pixar Stage Reference as the data in the combo box and move to the StageEntry which encapsulates both stage and the proxy shape path.

We can have a situation where we have multiple proxy shapes that point to the same exact stage, using the InStageData port. Unfortunately this causes an issue in the layer editor since the combo-box is keeping track of the stage only, so two entries with the same stage is ambiguous. 

The fix was to move away from storing the Pixar Stage Reference as the data in the combo box and move to the StageEntry which encapsulates both stage and the proxy shape path.
@alsoussi alsoussi added the ready-for-merge Development process is finished, PR is ready for merge label Mar 4, 2021
@kxl-adsk kxl-adsk merged commit 6558ee8 into dev Mar 5, 2021
@kxl-adsk kxl-adsk deleted the t-al-sa/MAYA-110196/layer_editor_same_stage_bug branch March 5, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants