Optimized repr update, wireframe and BBox display, proxy transformation and visibility #112

huidong-chen · 2019-11-12T17:10:15Z

Optimized VP2RenderDelegate repr update.
Added wireframe display for USD mesh.
Added bbox display for USD mesh (BBox will be hidden for Rprims without authored extent).
Added proxy shape transformation and visibility support (refactoring_sandbox : VP2 Delegate : Hiding ProxyShape Does Not Work #70, refactoring_sandbox : VP2 Delegate : Moving Proxy Shape Does Not Update Prim Positions in Viewport #71, refactoring_sandbox : Hydra : Moved USD Proxy makes Prim selection highlight still behave as if at origin #82)

kxl-adsk

We already reviewed it internally.

cfmoore007 · 2019-11-12T18:00:39Z

Thanks for the updates !

Here are my results :

#70 ( hiding proxy shape) still does not work for me.

It only seems to work after I do a ogs -reset

However, I can confirm the following work:

boundingBox
wireframe
wireframe on shaded
moving the proxy updates in the viewport ( along with associated selections )

cfmoore007 · 2019-11-12T18:04:57Z

AL Unit test works in UI, but crashes in prompt mode :
`mel: loadPlugin AL_USDMayaTestPlugin
VP2_RENDER_DELEGATE_PROXY is overridden to 'true'. Default is 'false'.
Stack trace:
OGSMayaVertexBuffer::createOGSVertexBuffer(unsigned int, OGS::Devices::AVertexFormat*, bool, OGS::Devices::EResourceUsage)
OGSMayaVertexBuffer::acquire(unsigned int, unsigned int, unsigned int, OGS::Devices::EAccessFlags)
pxrInternal_v0_19__pxrReserved__::HdVP2BBoxGeom::HdVP2BBoxGeom()
maya_usd/0.1.0.bss.7.dev/base_platform-maya2019-dist-up2.1.bss0/USD-19.11.bss.0/plugin/al/plugin/../../../lib/libmayaUsd.so(+0x67b7e) [0x7f1dc2ddeb7e]
/lib64/ld-linux-x86-64.so.2(+0xf8f3) [0x7f1ebcfdd8f3]
/lib64/ld-linux-x86-64.so.2(+0x144ce) [0x7f1ebcfe24ce]
/lib64/ld-linux-x86-64.so.2(+0xf704) [0x7f1ebcfdd704]
/lib64/ld-linux-x86-64.so.2(+0x13abb) [0x7f1ebcfe1abb]
/lib64/libdl.so.2(+0xeeb) [0x7f1ea78dceeb]
/lib64/ld-linux-x86-64.so.2(+0xf704) [0x7f1ebcfdd704]
/lib64/libdl.so.2(+0x14ed) [0x7f1ea78dd4ed]
dlopen
TdynamicLoad::open(char const*, TdynamicLoad::TdynamicLoadMode)
Tplugin::primaryLoad(Tstring const&, Tstring*)
Tplugin::load(Tstring const&, Tstring*)
maya2019-dist-up2.1/lib/libOpenMaya.so(+0x463dd5) [0x7f1e71b2edd5]
maya2019-dist-up2.1/lib/libOpenMaya.so(+0x46480d) [0x7f1e71b2f80d]
maya2019-dist-up2.1/lib/libOpenMaya.so(+0x465446) [0x7f1e71b30446]
maya2019-dist-up2.1/lib/libCommandEngine.so(+0x589d4) [0x7f1ebab9d9d4]
maya2019-dist-up2.1/lib/libCommandEngine.so(+0x82ec1) [0x7f1ebabc7ec1]
maya2019-dist-up2.1/lib/libCommandEngine.so(+0x83091) [0x7f1ebabc8091]
SophiaExecutable::evaluate(void*)
TcommandEngine::executeCommand(Tstring const&, bool, bool, TmelCmdResult*, unsigned int)
Tapplication::start()
maya2019-dist-up2.1/bin/maya.bin() [0x40e236]
maya2019-dist-up2.1/bin/maya.bin() [0x40caa6]
__libc_start_main
maya2019-dist-up2.1/bin/maya.bin() [0x40caf5]

Result: untitled.ma
`

huidong-chen · 2019-11-12T18:11:52Z

@cfmoore007 Thanks a lot for such quickly feedback.

For visibility, could you add some repro steps?

For the crash, it is one of the crash I hit and fixed on Windows. Let me see if it is still there on Linux.

cfmoore007 · 2019-11-12T18:16:59Z

@HdC-adsk : here you go ...

load attached 3_Spheres.zip example
select proxy shape ( transform or shape )
ctrl-h to hide
( notice it is not hidden )
ogs -reset
( notice it's now hidden )

cfmoore007 · 2019-11-12T18:21:32Z

side note : this also seems to fix the crash - #69

However, it still does not show the duplicate proxyShape's stage. Will log that after this is merged

huidong-chen · 2019-11-12T18:25:01Z

I don't think it will fix the crash of duplicating proxy shape. It should have been fixed by some other change from @ppt-adsk. @ppt-adsk , has your fix merged to public dev?

kxl-adsk · 2019-11-12T18:30:07Z

Duplicate crash - the complete fix has not been merged in yet.

huidong-chen · 2019-11-12T20:03:28Z

@cfmoore007 I can reproduce the hiding issue. It can work if you hit "h" without ctrl, I am investigating the difference between h and Ctrl-h.

For the crash at HdVP2BBoxGeom, is there a repro step for me as well?

cfmoore007 · 2019-11-12T22:33:09Z

Hiding :

confirmed - 'h' works.

For the crash :

load maya in prompt mode
loadPlugin AL_USDMayaTestPlugin
crash

huidong-chen · 2019-11-12T22:36:31Z

@cfmoore007 Thanks for confirm.

I tried this command below and saw no crash.
maya -batch -command "loadPlugin AL_USDMayaTestPlugin"

How do you load maya in prompt mode? It looks like you can do it with two separate steps.

cfmoore007 · 2019-11-13T17:23:53Z

It crashes here with the command you provided and in maya -prompt ( interactive ) and via -command.
Digging deeper over here ..

huidong-chen · 2019-11-13T17:26:26Z

Hi @cfmoore007 ,

I am creating a branch with a potential fix (as I cannot reproduce it I cannot confirm). I will push it later and ask for your help to confirm. Appreciated as always.

home3d2001 · 2019-11-13T17:28:27Z

@cfmoore007 do you see this crash on other platforms e.g ( Windows or MacOSx )? Could be Linux specific.

huidong-chen · 2019-11-13T20:07:11Z

@kxl-adsk The new commit is to fix the crash in AL unit test crash in Maya prompt mode and the hiding issue (H works but Ctrl+H didn't).

huidong-chen · 2019-11-13T20:17:29Z

lib/render/vp2RenderDelegate/mesh.cpp

@@ -364,6 +364,13 @@ void HdVP2Mesh::Sync(
    HdDirtyBits* dirtyBits,
    const TfToken& reprToken)
 {
+    // We don't create a repr for the selection token because this token serves


There is an optimization in Hydra that would skip sync if a Rprim is invisible and has no visibility dirty bit:

https://github.com/PixarAnimationStudios/USD/blob/4b1162957b2ad219e1635c81de8343be490e41fc/pxr/imaging/lib/hd/rprim.cpp#L71

Due to this optimization, if we have a selection update before regular refresh, the scene dirty bit gets cleared in selection update and no sync can be invoked for the hiding proxy. Thus we need the earlier return for the selection update to reserver the scene dirty bits.

huidong-chen · 2019-11-13T20:25:27Z

lib/render/vp2RenderDelegate/proxyRenderDelegate.cpp

        _sceneDelegate->SetRootVisibility(isVisible);
+
+        // Trigger selection update when a hidden proxy shape gets shown.
+        if (isVisible) {


Trigger the selection update when an invisible proxy gets shown. To make this change, I also make the explicit check to see whether there is visibility change (which is checked inside SetRootVisibility() as well).

To make code consistent, I also refactored root transform part, a side benefit of this is the matrix comparison is done by approximation (GfIsClose) rather than equality. This is a TODO item inside SetRootTransform().

FWIW, we shouldn't do similar code change to skip SetTime() call when the time code is equivalent. SetTime() will apply pending edits before its internal time equality check.

huidong-chen · 2019-11-13T20:28:02Z

lib/render/vp2RenderDelegate/render_delegate.cpp

+        // future we should move this code out.
+        if (TF_VERIFY(sSharedBBoxGeom == nullptr)) {
+            sSharedBBoxGeom = new HdVP2BBoxGeom();
+        }


I couldn't repro the crash in AL unit test crash in Maya prompt mode. The callstack appears to indicate HdVP2BBoxGeom was instantiated before VP2 initialization. Thus I make this change to make sure it is instantiated after VP2 initialization.

AND @cfmoore007 helped to validate the fix before I pushing the commit.

Makes sense!

cfmoore007 · 2019-11-13T21:09:27Z

Just re-tested this PR. Looks like everything came through successfully :

unit test passes ( no crash in batch or prompt mode )
ctrl-h now properly hides the proxyShape ( toggle 'h' as well )
bounding box and wireframe modes also still work and are addressed here.

Thanks for the quick turn-around @HdC-adsk !

huidong-chen · 2019-11-13T21:18:30Z

@cfmoore007 Thanks for retesting and feedback as fast as always. Very much appreciated!

…mation-visibility

…urface_error

Huidong Chen added 4 commits November 12, 2019 11:15

MAYA-100929 wireframe display for USD

aba1ae8

MAYA-99443 Bounding box display for USD

961b57b

MAYA-99904 respect proxy transformation and visibility (#185)

0e23a73

MAYA-101928 Hide bbox for Rprims without authored extent (#186)

49b8a66

huidong-chen requested a review from kxl-adsk November 12, 2019 17:10

huidong-chen changed the title ~~Chenh/wireframe bbox reprs and proxy transformation visibility~~ Wireframe and BBox diplay, proxy transformation and visibility, optimized representation update Nov 12, 2019

huidong-chen changed the title ~~Wireframe and BBox diplay, proxy transformation and visibility, optimized representation update~~ Wireframe and BBox display, proxy transformation and visibility, optimized representation update Nov 12, 2019

huidong-chen changed the title ~~Wireframe and BBox display, proxy transformation and visibility, optimized representation update~~ Optimized repr update, wireframe and BBox display, proxy transformation and visibility Nov 12, 2019

kxl-adsk approved these changes Nov 12, 2019

View reviewed changes

BigRoy mentioned this pull request Nov 13, 2019

refactoring_sandbox : Hydra : Moved USD Proxy makes Prim selection highlight still behave as if at origin #82

Closed

Fix crash and hiding issue reported by BSKY.

6280cea

huidong-chen commented Nov 13, 2019

View reviewed changes

huidong-chen requested a review from kxl-adsk November 13, 2019 20:51

kxl-adsk approved these changes Nov 13, 2019

View reviewed changes

Merge branch 'dev' into chenh/wireframe-bbox-reprs-and-proxy-transfor…

0e9a14d

…mation-visibility

huidong-chen merged commit 247677c into dev Nov 13, 2019

huidong-chen deleted the chenh/wireframe-bbox-reprs-and-proxy-transformation-visibility branch November 13, 2019 21:25

This was referenced Nov 13, 2019

refactoring_sandbox : VP2 Delegate : Hiding ProxyShape Does Not Work #70

Closed

refactoring_sandbox : VP2 Delegate : Moving Proxy Shape Does Not Update Prim Positions in Viewport #71

Closed

pmolodo pushed a commit to LumaPictures/maya-usd that referenced this pull request Jan 22, 2020

Merge pull request Autodesk#112 from maya3d/sabrih/fix_pxrUsdPreviewS…

dfc77fa

…urface_error

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimized repr update, wireframe and BBox display, proxy transformation and visibility #112

Optimized repr update, wireframe and BBox display, proxy transformation and visibility #112

huidong-chen commented Nov 12, 2019 •

edited

Loading

kxl-adsk left a comment

cfmoore007 commented Nov 12, 2019 •

edited

Loading

cfmoore007 commented Nov 12, 2019

huidong-chen commented Nov 12, 2019

cfmoore007 commented Nov 12, 2019 •

edited

Loading

cfmoore007 commented Nov 12, 2019

huidong-chen commented Nov 12, 2019

kxl-adsk commented Nov 12, 2019

huidong-chen commented Nov 12, 2019

cfmoore007 commented Nov 12, 2019 •

edited

Loading

huidong-chen commented Nov 12, 2019

cfmoore007 commented Nov 13, 2019

huidong-chen commented Nov 13, 2019

home3d2001 commented Nov 13, 2019

huidong-chen commented Nov 13, 2019

huidong-chen Nov 13, 2019

huidong-chen Nov 13, 2019

huidong-chen Nov 13, 2019

huidong-chen Nov 13, 2019

kxl-adsk Nov 13, 2019

cfmoore007 commented Nov 13, 2019

huidong-chen commented Nov 13, 2019

Optimized repr update, wireframe and BBox display, proxy transformation and visibility #112

Optimized repr update, wireframe and BBox display, proxy transformation and visibility #112

Conversation

huidong-chen commented Nov 12, 2019 • edited Loading

kxl-adsk left a comment

Choose a reason for hiding this comment

cfmoore007 commented Nov 12, 2019 • edited Loading

cfmoore007 commented Nov 12, 2019

huidong-chen commented Nov 12, 2019

cfmoore007 commented Nov 12, 2019 • edited Loading

cfmoore007 commented Nov 12, 2019

huidong-chen commented Nov 12, 2019

kxl-adsk commented Nov 12, 2019

huidong-chen commented Nov 12, 2019

cfmoore007 commented Nov 12, 2019 • edited Loading

huidong-chen commented Nov 12, 2019

cfmoore007 commented Nov 13, 2019

huidong-chen commented Nov 13, 2019

home3d2001 commented Nov 13, 2019

huidong-chen commented Nov 13, 2019

huidong-chen Nov 13, 2019

Choose a reason for hiding this comment

huidong-chen Nov 13, 2019

Choose a reason for hiding this comment

huidong-chen Nov 13, 2019

Choose a reason for hiding this comment

huidong-chen Nov 13, 2019

Choose a reason for hiding this comment

kxl-adsk Nov 13, 2019

Choose a reason for hiding this comment

cfmoore007 commented Nov 13, 2019

huidong-chen commented Nov 13, 2019

huidong-chen commented Nov 12, 2019 •

edited

Loading

cfmoore007 commented Nov 12, 2019 •

edited

Loading

cfmoore007 commented Nov 12, 2019 •

edited

Loading

cfmoore007 commented Nov 12, 2019 •

edited

Loading