MAYA-108274 Skip creating shader instance for unchanged material network #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip creating a new shader instance if the token generated from the material network is unchanged. There is no plan to implement fine-grain dirty bit in Hydra for the same purpose: https://groups.google.com/g/usd-interest/c/xytT2azlJec/m/22Tnw4yXAAAJ
JGamache-autodesk
approved these changes
Jan 11, 2021
kxl-adsk
approved these changes
Jan 11, 2021
|
@kxl-adsk Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip creating a new shader instance if the token generated from the material
network is unchanged. There is no plan to implement fine-grain dirty bit in
Hydra for the same purpose:
https://groups.google.com/g/usd-interest/c/xytT2azlJec/m/22Tnw4yXAAAJ