MAYA-106310 - Crash when querying target layer and nothing is assigne… #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the target - Update the mayaUsdLayerEditor cmd to set the root layer as the edit target when the command is used the remove a layer and this layer is the edit target
|
Removed a layer that's the current edit target with the command mayaUsdLayerEditor will cause a crash when querying the current edit target. UsdStage will return a dangling pointer when the edit layer is removed. To fix this issue, I updated the command mayaUsdLayerEditor to set the root layer as the edit layer when removing a layer and this layer is the edit target. To be able to access to the UsdStage inside the command, I updated the signature for removing a layer.
|
…d the target - clang format
…d the target - clang format
kxl-adsk
approved these changes
Dec 22, 2020
| if (currentTarget | ||
| && currentTarget->GetIdentifier() == subLayerHandle->GetIdentifier()) { | ||
| _isEditTarget = true; | ||
| stage->SetEditTarget(stage->GetRootLayer()); |
There was a problem hiding this comment.
Would be worth considering matching the logic with base proxy shape, ie fallback to session layer of root layer can’t be edited or we forced session layer with option var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d the target