Fix a build issue on Linux with maya<2020 #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On maya<=2019, maya ends up including Xlib.h, which does ``` #define Bool int ``` ...which messes with SdfValueTypeNames->Bool. So on Linux with Maya<2020, this just does an `#undef Bool`. This may only be an issue on specific Linux distributions, since it's tied to the system supplied GL/glx.h and Xlib.h headers.
|
Ugh, yeah, we tripped over that as well and ended up littering a bunch of code with early The awful details are described here: But I notice the include of |
kxl-adsk
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On maya<=2019, maya ends up including Xlib.h, which does
...which messes with SdfValueTypeNames->Bool. So on Linux with Maya<2020,
this just does an
#undef Bool.This may only be an issue on specific Linux distributions, since it's tied
to the system supplied GL/glx.h and Xlib.h headers.