Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pxr] get tests building / working for pixar plugin #100

Closed
wants to merge 1 commit into from

Conversation

pmolodo
Copy link
Contributor

@pmolodo pmolodo commented Nov 5, 2019

This contains changes necessary to get the pixar tests building / running in the dev branch.

Note that some changes here could potentially affect things other than tests (ie, there are some rpath changes I needed to get tests to run). so having someone else verify that everything still works for them would be good!

@HamedSabri-adsk HamedSabri-adsk added the do-not-merge-yet Development is not finished, PR not ready for merge label Nov 5, 2019
@HamedSabri-adsk
Copy link
Contributor

@elrond79 We have already started the work on getting the unit tests working on all 3 platforms in refactoring_sandbox including fixes for rpaths, etc... We haven't merged the changes yet into dev.

@kxl-adsk
Copy link

kxl-adsk commented Nov 5, 2019

In fact, quite a lot of this work is included in #91. @elrond79 have a look at this PR.

@pmolodo
Copy link
Contributor Author

pmolodo commented Nov 5, 2019

Yes, but we want tests working BEFORE we merge in big changes. For two reasons:

  1. We're planning to make the current dev (before merging in big changes) become the new master. If we don't fix tests first, the "master" branch - the one that's supposed to be stable, and we want people to use in production - won't have working tests. This is unacceptable for a production environment.

  2. We want a baseline before we merge in big changes. That way, when tests fail after, we know it's a breaking change.

I'm fine if we want to modify this to be more in line with what's coming in #91, etc... (though I did make some attempt to mirror what's coming - ie, I used the same "BUILD_TESTS" cmake var you folks introduced)... however, I definitely think we need to get tests working before bringing in the big changes.

@pmolodo pmolodo changed the base branch from dev to master November 12, 2019 19:34
@pmolodo
Copy link
Contributor Author

pmolodo commented Dec 12, 2019

Dropping this PR, as all the fixes here have been addressed in other branches / PRs!

@pmolodo pmolodo closed this Dec 12, 2019
pmolodo pushed a commit to LumaPictures/maya-usd that referenced this pull request Jan 22, 2020
* Factored out scene assembly from base readJob class.

* Factored code to remove REFACTOR_PROXY_SHAPE.

* Factored reference assembly out of instancerImager.

* Factored reference assembly out of instancerShapeAdapter.

* Enabled used of derived instancer shape adapter factory.
robthebloke pushed a commit to AnimalLogic/maya-usd that referenced this pull request Sep 10, 2020
…aths_after_translate_prim

the GL imaging engine was not being reconstructed after a translate prim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge-yet Development is not finished, PR not ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants