Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAYA-107167] USDZ export writes paths that aren't inclusive to the usdz #795

Closed
dgovil opened this issue Sep 23, 2020 · 1 comment · Fixed by #865
Closed

[MAYA-107167] USDZ export writes paths that aren't inclusive to the usdz #795

dgovil opened this issue Sep 23, 2020 · 1 comment · Fixed by #865
Assignees
Labels
bug Something isn't working regression Something that used to work is no longer working

Comments

@dgovil
Copy link
Collaborator

dgovil commented Sep 23, 2020

Describe the bug
There was a regression to this repo that caused usdz files to write references that aren't inclusive to the zip file.
Previously, the paths would be written relative to the internals of the usdz and would include the referenced dependencies into the usdz file, however this no longer works.

This was due to a change in cb77d92c63 lib/usd/translators/shading/usdFileTextureWriter.cpp
Steps to reproduce
Steps to reproduce the behavior:

  1. Export asset as a usdz
  2. Check the file path reference on the Shader file1 prim.

Expected behavior
Prior to this change, the filepath would resolve as 0/checkerboard.png since the path and texture would be inlined into the usdz.
After this change, the path is relative to the workspace and no longer inlines the texture into the zip.

We disabled this block of code, and it's back to the expected behaviour, so I think revisiting this code will resolve the issue.

Attachments
I've attached the Maya workspace this is generated from, and the usdz is inside it as well

bugreports.zip

Specs (if applicable):

  • macOS Catalina and Big Sur
  • Compiler version: Apple clang version 12.0.0 (clang-1200.0.32.5) (reproducible on older clang versions too)
  • Maya 2018.5 and 2020.0
  • Maya USD commit SHA 4365cc6
  • Pixar USD commit SHA 71b4baace2044ea4400ba802e91667f9ebe342f0

Additional context
We are still using pxrUSD.bundle to do our exporting.

@dgovil dgovil added the bug Something isn't working label Sep 23, 2020
@kxl-adsk
Copy link

Thanks for reporting @dgovil. We knew we are taking shortcuts here. I will let @JGamache-autodesk investigate and comment.

@santosg87 santosg87 changed the title USDZ export writes paths that aren't inclusive to the usdz [MAYA-107167] USDZ export writes paths that aren't inclusive to the usdz Sep 30, 2020
@kxl-adsk kxl-adsk added the regression Something that used to work is no longer working label Oct 6, 2020
JGamache-autodesk added a commit that referenced this issue Oct 23, 2020
If the path requires a relationship to resolves, we keep it relative.
Fixes #795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something that used to work is no longer working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants