Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please don't touch fly state #1280

Closed
Platinteufel opened this issue Jul 9, 2017 · 4 comments
Closed

Please don't touch fly state #1280

Platinteufel opened this issue Jul 9, 2017 · 4 comments
Assignees
@ljacqu
Labels
Type: enhancement
Milestone
5.4.0

Comments

@Platinteufel
Copy link
Contributor

Platinteufel commented Jul 9, 2017 •
edited
Loading

From Discord:

Since I've updated to the latest AuthMe version today it doesn't restore the flying state properly (if I logout in the air while flying, it will disable fly at next login and the players will get fall damage)
I'm using the default config. I've tried everything. After login my fly is disabled and I fall to bottom.

It was fine in 5.2 .. Essentials just enabled fly for me if I was in the air and had the permission essentials.fly.safelogin. But it seems like AuthMe overrides this Essentials feature after /login and sets the flying state back to false.
If I deinstall AuthMe, Essentials does its job again, as you can see here: https://youtu.be/EI2wuZs4ON4

Correct me if I'm wrong, but all AuthMe should do is setting players speed to 0 and restore it back to its old value as soon as the player is logged in .. ? I don't really know why it touches things like flying state 😄
Platinteufel referenced this issue Jul 9, 2017
@ljacqu
#1036 Add restoration options for Limbo allowFlight / fly speed / wal…
c766b5c 
…k speed

- Introduce options to define how allow flight, fly & walk speed should be restored from LimboPlayer
- Create consistency tests for line length in SectionComments methods and to ensure that all SettingsHolder classes are part of the returned ConfigurationData
@Platinteufel
Copy link
Contributor Author

Please also take a look at my comment referenced above. Maybe an option to do nothing would do it?

@ljacqu ljacqu self-assigned this Jul 10, 2017
ljacqu added a commit that referenced this issue Jul 10, 2017
@ljacqu
#1280 Add NOTHING as possible flight restore type
e1826c7
@ljacqu
Copy link
Member

ljacqu commented Jul 10, 2017

Hi @Platinteufel , a new option NOTHING has been added. When it is chosen, AuthMe will not manipulate the allow flight property of the player in any way. Available in build n. 1739 and above at http://ci.xephi.fr/job/AuthMeReloaded/

@ljacqu ljacqu added this to the 5.3.3 milestone Jul 10, 2017
@Platinteufel
Copy link
Contributor Author

Hi @ljacqu,
it works like a charm, thanks a lot for implementing this special case!

@ljacqu
Copy link
Member

ljacqu commented Jul 10, 2017

Well, thanks for the detailed report and for the prompt feedback :) In that case I close this issue.

@ljacqu ljacqu closed this as completed Jul 10, 2017
@ljacqu ljacqu modified the milestones: 5.3.3, 5.4 Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljacqu ljacqu

Labels
Type: enhancement
Milestone
5.4.0
Development

No branches or pull requests
2 participants
@ljacqu @Platinteufel