Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: TH warnings #30

Open
nohelix opened this issue Feb 4, 2023 · 1 comment
Open

Bug: TH warnings #30

nohelix opened this issue Feb 4, 2023 · 1 comment
Labels
at: import/main.R bug Something isn't working discussion Further information is requested

Comments

@nohelix
Copy link
Collaborator

nohelix commented Feb 4, 2023

thresholding (i.e. psycho) likes to spit out warnings in different cases

Example bad files found in Z:\Issues:

  • 9/26/22 LP3 Note this also gives an additional error of unknown column FA
  • 8/29/22 BP3
@nohelix nohelix added the bug Something isn't working label Feb 4, 2023
@nohelix nohelix self-assigned this Feb 4, 2023
@nohelix nohelix added the discussion Further information is requested label Feb 22, 2023
@nohelix
Copy link
Collaborator Author

nohelix commented Feb 22, 2023

So the warnings are typically do to low trial counts and trying to fit a line to a weak model. It seems like we should try to capture the warnings from approx() that are returned during the map and convert them to a single warning in warnings_list that says "Calculated TH is questionable to to poor modeling conditions."

Not sure how to program that.

nohelix added a commit that referenced this issue Feb 22, 2023
addresses part of #30
nohelix added a commit that referenced this issue Feb 22, 2023
nohelix added a commit that referenced this issue Feb 22, 2023
@tofof tofof mentioned this issue Aug 10, 2023
@tofof tofof added this to the TH calculation rework milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
at: import/main.R bug Something isn't working discussion Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants