Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

QA-588 Fix collection card profile link #3853

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

nicoback2
Copy link
Contributor

Description

https://linear.app/audius/issue/QA-588/[qa]-artist-names-on-album-tiles-failing-to-redirect
Before: When a user clicks on an artist's name in an album tile, they are redirected through the profile to the album, rather than just being directed to the artist's profile.

After: Fixed

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

@nicoback2 nicoback2 requested review from Kyle-Shanks and a team August 4, 2023 19:08
Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/nkang--album-user-link

@nicoback2 nicoback2 merged commit f5320be into main Aug 9, 2023
@nicoback2 nicoback2 deleted the nkang--album-user-link branch August 9, 2023 16:20
schottra added a commit that referenced this pull request Aug 9, 2023
* origin/main:
  [C-2930] Fix extra space after username in tip to unlock modal (#3845)
  QA-588 Fix collection card profile link  (#3853)
  Fix broken playlist fetch via resolve (#3863)
  [PAY-1695] DMs: Entrypoint Analytics (#3862)
  Minor improvements to SEO flow merged in #3859 (#3861)
audius-infra pushed a commit that referenced this pull request Aug 12, 2023
[3436c20] [PAY-1701] Fix "Share to DMs" to work through InboxUnavailableModal (#3874) Marcus Pasell
[a740243] Add sdk:update-hotfix (#3875) Dylan Jeffers
[a25fd19] [C-2759] Make donation link external (#3872) Dylan Jeffers
[15f056c] [PAY-1630] Wire up purchase content sagas (#3834) Randy Schott
[998d44b] Fix mobile crash on drawer dismiss (#3871) Reed
[7d0e0b3] [PAY-1430] "Leaving Audius" Warning for External Links (and createModal helper) (#3860) Marcus Pasell
[bee8bd1] Remove .only on upload cypress test (#3869) Raymond Jacobson
[4c0b25f] [C-2926] Implement selected values for upload contextual menu fields (#3848) Dylan Jeffers
[5773578] Preserve CIDs for track and collection cover arts (#3866) Marcus Pasell
[be0d278] [C-2930] Fix extra space after username in tip to unlock modal (#3845) nicoback2
[f5320be] QA-588 Fix collection card profile link  (#3853) nicoback2
[360416e] Fix broken playlist fetch via resolve (#3863) Raymond Jacobson
[2dc2c29] [PAY-1695] DMs: Entrypoint Analytics (#3862) Marcus Pasell
[f80d366] Minor improvements to SEO flow merged in #3859 (#3861) Raymond Jacobson
[b99d62f] Add nodes to env for SEO support (#3859) Raymond Jacobson
[20476ee] [C-2941] Modify cloudflare worker to pull in SEO data from discovery nodes (#3858) Raymond Jacobson
[7f79830] [C-2879] Add validation to single track upload flow (#3855) Kyle Shanks
[6f4fc89] [C-2940] Update google analytics tags and fix embed build (#3856) Raymond Jacobson
[3469c89] [C-2852 PLAT-1094 PLAT-1093] Add fetch collection by permalink (#3751) Dylan Jeffers
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants