Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

[C-2846] Suggested Tracks QA #3771

Merged
merged 3 commits into from
Jul 19, 2023
Merged

[C-2846] Suggested Tracks QA #3771

merged 3 commits into from
Jul 19, 2023

Conversation

dylanjeffers
Copy link
Contributor

@dylanjeffers dylanjeffers commented Jul 19, 2023 •
edited
Loading

Description

  • add toast alert when suggested track is added
  • Icon caret down vs icon down line
  • Static height + skeletons for mobile
  • Update drag to reorder to only have touch target on the drag icon
  • See if we can improve lineup loading state after adding element
  • Padding on the track list does not match the padding of the text above (i.e. tracks and modified and such)
  • Fix artist name in add-some-tracks
  • Filter out collectible gated content from trending

@dylanjeffers dylanjeffers requested review from Kyle-Shanks and a team July 19, 2023 22:11
Kyle-Shanks
Kyle-Shanks reviewed Jul 19, 2023
View reviewed changes
packages/mobile/src/components/track-list/TrackListItem.tsx Outdated
Comment on lines 108 to 109
icon: { height: spacing(6), width: spacing(6) },
removeIcon: { height: spacing(6), width: spacing(6) },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the values for icon height and width changed, making sure thats intentional. also seems weird to use spacing for the height and width of things 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it was intentional, and good point about using spacing, i just went with it to be consistent with other times ive seen it used for height and width....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ewww, sounds good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lolll ill change it, please please sir i just found it on the ground

Kyle-Shanks
Kyle-Shanks reviewed Jul 19, 2023
View reviewed changes
packages/mobile/src/components/track-list/TrackList.tsx Outdated
if (showSkeleton)
return (
<FlatList {...otherProps} data={data} renderItem={renderSkeletonTrack} />
)

console.log({ scrollEnable })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log

@dylanjeffers dylanjeffers merged commit 62a0c72 into main Jul 19, 2023
@dylanjeffers dylanjeffers deleted the dj-c-2846-suggested-tracks-qa branch July 19, 2023 22:23
dylanjeffers added a commit that referenced this pull request Jul 19, 2023
@dylanjeffers
[C-2846] Suggested Tracks QA (#3771)
d5b072d
dylanjeffers added a commit that referenced this pull request Jul 24, 2023
@dylanjeffers
v1.5.34
f658896 
[72ec48f] Upgrade to 1.5.33 Dylan Jeffers
[9ec1f54] Update to reroute to trending when deleting a playlist if the playlist is viewed (#3789) Kyle Shanks
[5cbc230] [C-2877] Address suggested-tracks qa #2 (#3787) Dylan Jeffers
[4ad7987] [PAY-1652] Update LockedContentDrawer on mobile (#3786) Reed
[5e2337c] Fix mobile premcontent locked badge colors (#3783) Reed
[19cca4c] Change mobile drawer background to white (#3784) Reed
[05b7d1f] [PAY-1635] Always show share button for track owners on hidden tracks (#3782) Randy Schott
[ca66d4d] [PAY-1575] Always show premium DogEars on track details page (#3781) Randy Schott
[46f41a8] [PAY-1620] Fix disabled play button for unlocked gated tracks on Mobile Web (#3779) Randy Schott
[44666b2] [PAY-1615] Fix display of "Artist Pick" text (#3780) Randy Schott
[3e24539] [PAY-1618] Update DogEar rendering and fix spacing (#3775) Randy Schott
[bb28a09] [C-2866] Undo secondary button style changes (#3777) Randy Schott
[699f8f6] [PAY-1634] Fix hidden track tile + add share button (#3765) Reed
[1d95e73] Add support for UDSC Mint in Client (#3776) Marcus Pasell
[79d85f1] [PAY-1638] Fix iconLockUnlocked icon (#3766) Reed
[b63107b] [C-2872] Fix image retries (#3773) Dylan Jeffers
[b99b93a] Add fallback url to embed (#3772) Raymond Jacobson
[5adb25b] Remove usages of CN /health_check/verbose (#3769) Theo Ilie
[62a0c72] [C-2846] Suggested Tracks QA (#3771) Dylan Jeffers
[9c87fb2] [C-2861] Replace private with hidden (#3768) Dylan Jeffers
[87f7f35] [C-2650] Add playlist-library sanitization hook (#3767) Dylan Jeffers
[8ba6d04] Add Dapp store publishing in CI (#3747) Raymond Jacobson
[9324a06] [C-2842] Improve playlist image generation (#3762) Dylan Jeffers
[9c5a412] Remove unused notification announcement page (#3739) Reed
[5023cef] [C-2853] Fix deletedCount calculation (#3763) Andrew Mendelsohn
[b627216] [PAY-1639] Fix mobile hidden track dog ear (#3764) Reed
[40ea57e] [C-2856] Fix track/collection artwork field (#3760) Dylan Jeffers
[366e4df] [C-2858] Fix phantom signing (#3761) Raymond Jacobson
[8a7cbc7] [PAY-1621] Reverse order of mobile lineup tile stat icon and number (#3759) Reed
[9206ab0] [PAY-1612] Change mobile hidden track header color (#3758) Reed
[745ff35] Use Text component in mobile DMs (#3749) Reed
[1afc426] [PAY-1607] Fix mobile prem content track tile layout (#3757) Reed
[07f0f6c] [PAY-1606] Updates gated content experience  (#3754) Randy Schott
[a82e296] v1.5.32 Dylan Jeffers
dharit-tan pushed a commit that referenced this pull request Jul 24, 2023
@dylanjeffers @dharit-tan
v1.5.34
bbbd666 
[72ec48f] Upgrade to 1.5.33 Dylan Jeffers
[9ec1f54] Update to reroute to trending when deleting a playlist if the playlist is viewed (#3789) Kyle Shanks
[5cbc230] [C-2877] Address suggested-tracks qa #2 (#3787) Dylan Jeffers
[4ad7987] [PAY-1652] Update LockedContentDrawer on mobile (#3786) Reed
[5e2337c] Fix mobile premcontent locked badge colors (#3783) Reed
[19cca4c] Change mobile drawer background to white (#3784) Reed
[05b7d1f] [PAY-1635] Always show share button for track owners on hidden tracks (#3782) Randy Schott
[ca66d4d] [PAY-1575] Always show premium DogEars on track details page (#3781) Randy Schott
[46f41a8] [PAY-1620] Fix disabled play button for unlocked gated tracks on Mobile Web (#3779) Randy Schott
[44666b2] [PAY-1615] Fix display of "Artist Pick" text (#3780) Randy Schott
[3e24539] [PAY-1618] Update DogEar rendering and fix spacing (#3775) Randy Schott
[bb28a09] [C-2866] Undo secondary button style changes (#3777) Randy Schott
[699f8f6] [PAY-1634] Fix hidden track tile + add share button (#3765) Reed
[1d95e73] Add support for UDSC Mint in Client (#3776) Marcus Pasell
[79d85f1] [PAY-1638] Fix iconLockUnlocked icon (#3766) Reed
[b63107b] [C-2872] Fix image retries (#3773) Dylan Jeffers
[b99b93a] Add fallback url to embed (#3772) Raymond Jacobson
[5adb25b] Remove usages of CN /health_check/verbose (#3769) Theo Ilie
[62a0c72] [C-2846] Suggested Tracks QA (#3771) Dylan Jeffers
[9c87fb2] [C-2861] Replace private with hidden (#3768) Dylan Jeffers
[87f7f35] [C-2650] Add playlist-library sanitization hook (#3767) Dylan Jeffers
[8ba6d04] Add Dapp store publishing in CI (#3747) Raymond Jacobson
[9324a06] [C-2842] Improve playlist image generation (#3762) Dylan Jeffers
[9c5a412] Remove unused notification announcement page (#3739) Reed
[5023cef] [C-2853] Fix deletedCount calculation (#3763) Andrew Mendelsohn
[b627216] [PAY-1639] Fix mobile hidden track dog ear (#3764) Reed
[40ea57e] [C-2856] Fix track/collection artwork field (#3760) Dylan Jeffers
[366e4df] [C-2858] Fix phantom signing (#3761) Raymond Jacobson
[8a7cbc7] [PAY-1621] Reverse order of mobile lineup tile stat icon and number (#3759) Reed
[9206ab0] [PAY-1612] Change mobile hidden track header color (#3758) Reed
[745ff35] Use Text component in mobile DMs (#3749) Reed
[1afc426] [PAY-1607] Fix mobile prem content track tile layout (#3757) Reed
[07f0f6c] [PAY-1606] Updates gated content experience  (#3754) Randy Schott
[a82e296] v1.5.32 Dylan Jeffers
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kyle-Shanks Kyle-Shanks Kyle-Shanks approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanjeffers @Kyle-Shanks