Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

[C-2465] Improve audius-query cache selection performance #3687

Merged
merged 1 commit into from
Jun 30, 2023
Merged

[C-2465] Improve audius-query cache selection performance #3687

merged 1 commit into from
Jun 30, 2023

Conversation

dylanjeffers
Copy link
Contributor

Description

Improves query cache performance by checking denormalized result with isEqual. This is a temporary fix until we can update denormalize function to properly select from cache.

@dylanjeffers dylanjeffers requested a review from amendelsohn June 30, 2023 21:26
amendelsohn
amendelsohn approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So glad this works!

packages/common/src/audius-query/createApi.ts
@@ -143,7 +142,7 @@ const useQueryState = <Args, Data>(
reducerPath: string,
endpointName: string,
endpoint: EndpointConfig<Args, Data>
) => {
): Nullable<PerKeyState<any> & { isInitialValue?: boolean }> => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does PerKeyState<Data> work? Maybe not cause it's like PerKeyState<Normalized<Data> really

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah i see i can try that, the main thing was complaining about isInitialValue not being a port of PerStateKey

packages/common/tsconfig.json
@@ -3,6 +3,7 @@
"outDir": "dist",
"baseUrl": ".",
"paths": {
"audius-query": ["src/audius-query/index.ts"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes absolute imports possible, which i kinda like with audius-query cause it's kinda like it's own package

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH that's cool

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/dj-fix-audius-query-cache-performance

@dylanjeffers dylanjeffers merged commit dcd67b9 into main Jun 30, 2023
@dylanjeffers dylanjeffers deleted the dj-fix-audius-query-cache-performance branch June 30, 2023 22:21
schottra added a commit that referenced this pull request Jul 7, 2023
@schottra
Merge branch 'main' into gated-content-updates
ed1ea03 
* main: (36 commits)
  [PAY-1566] Adds support for passing color directly to primary button (#3709)
  [C-2825] Fix push notification registration (#3672)
  [C-2827] Fix hidden dog ear on search results (#3708)
  [C-2830] Move storage node selector to common (#3707)
  [C-1379] Add link to playlist in mobile toast (#3702)
  [C-2821] Add hidden dog tag to mobile card (#3701)
  [C-2587] Fix playlist update tooltip (#3700)
  [QA-560][PAY-1564] Fix hot and new bug (#3703)
  [PAY-1563] Fix loading into a chat from a push notification (#3699)
  [C-2478 C-2480] Add suggestedTracks (#3689)
  Attach ulid package to window (#3697)
  Fix track screen artist name font weight (#3695)
  [C-2416] Fix missing hidden playlists on own profile (#3694)
  Fetch chats on app foreground (#3693)
  [C-2718] Fix mobile sign-up environment issues (#3691)
  Update SDK to v3.0.3-beta.63 (#3688)
  OAuth and Developer Apps QA C-2816 C-2815 C-2794 C-2793 C-2795 C-2797 (#3681)
  [C-2465] Improve audius-query cache selection performance (#3687)
  [C-2799] Disallow protected m4p file uploads (#3686)
  [PAY-1535] Refresh chat messages on render and pull to refresh on chats list (#3673)
  ...
dylanjeffers added a commit that referenced this pull request Jul 17, 2023
@dylanjeffers
v1.5.32
a82e296 
[cd49430] Manually set the libs state to prevent retry storm (#3753) Michael Piazza
[83feb57] Fix android announcement notifs (#3750) Michael Piazza
[e375a3f] [PAY-1599] Fix font in Start Conversation prompt (#3748) Reed
[9468b70] [C-2851] Add privacy policy to settings page (#3741) Dylan Jeffers
[bb67f44] [PAY-1595] Hide chat textinput until chat exists (#3746) Reed
[a11cbf1] [PAY-1597] Fix mobile chat screen empty state font (#3744) Reed
[f9e5afa] Bump Android again (#3745) Michael Piazza
[6d009ae] Get the first storage node for o-auth not all of them (#3743) Andrew Mendelsohn
[84bddc0] Bump app versions (#3742) Michael Piazza
[c31a97d] Notification cursor reflects clickability (#3740) Reed
[de56d62] [C-2823] Improve autogenerated image logic (#3729) Dylan Jeffers
[37d76af] [C-1608 C-2750] Fix edit profile/cover photo (#3735) Dylan Jeffers
[97368b1] [C-2711] Remove app-store link in force-upgrade for saga (#3737) Dylan Jeffers
[9c30287] Pin lerna version (#3738) Sebastian Klingler
[21eafd7] Update announcement notification style and hover behavior retry (#3736) Reed
[1aca4db] [CON-765] Default v2 signup and fix local EM (#3730) Theo Ilie
[b458446] Update announcement notification style and hover behavior (#3733) Reed
[c097955] Update announcement notification style and hover behavior (#3733) Reed
[e6e59f6] [C-2844] Ensure all tracks fetched on collection page (#3734) Andrew Mendelsohn
[be5a951] Add dev storage bootstrap nodes (#3731) Sebastian Klingler
[a71526d] [QA-565] Fix notification overflow bug (#3732) Reed
[ddb558e] [C-2547] Lineup pagination fixes (#3728) Andrew Mendelsohn
[c341156] [C-2679] Track Availability Modal Form (#3720) Andrew Mendelsohn
[bacde06] [C-2785] Update collection screen focus effect to fetch lineup (#3722) Kyle Shanks
[f870bd2] Make embed not fetch metadata from CN (#3710) Theo Ilie
[0fa16c6] [C-2809] Remove user from image hooks (#3723) Dylan Jeffers
[ca163ef] [C-2834] Remove replica set usage in web (#3721) Dylan Jeffers
[46f2974] [C-2829] Finalize SuggestedTracks (#3706) Dylan Jeffers
[8a4b7e8] [PAY-1569] Update blog post link (#3719) Michael Piazza
[58070df] Call the DN selection callback in AudiusBackend if using a cached DN (#3718) Marcus Pasell
[5e5fdd3] DMs: Add space to learn more text (#3714) Marcus Pasell
[1430c7e] DMs: Ensure every permission action has a CTA (#3716) Marcus Pasell
[6def75a] Revert "[PAY-1534] Allow Popup to be mounted inside a container (#3669)" (#3715) Marcus Pasell
[aa9f49f] DMs: Make links noreferrer noopener (#3713) Marcus Pasell
[8bc0a02] [PAY-1463] Fix d to set discovery node (#3690) Marcus Pasell
[12fe88d] [PAY-1534] Allow Popup to be mounted inside a container (#3669) Marcus Pasell
[a51c83e] [C-2341] Update tracks table to display tracks marked as deleted as deleted (#3712) Kyle Shanks
[23ad32e] [PAY-1566] Adds support for passing color directly to primary button (#3709) Randy Schott
[79da3ee] [C-2825] Fix push notification registration (#3672) Michelle Brier
[475e14e] [C-2827] Fix hidden dog ear on search results (#3708) Dylan Jeffers
[946732b] [C-2830] Move storage node selector to common (#3707) Dylan Jeffers
[cd0b911] [C-1379] Add link to playlist in mobile toast (#3702) Dylan Jeffers
[4059fe8] [C-2821] Add hidden dog tag to mobile card (#3701) Dylan Jeffers
[61927c4] [C-2587] Fix playlist update tooltip (#3700) Dylan Jeffers
[597f21c] [QA-560][PAY-1564] Fix hot and new bug (#3703) Saliou Diallo
[80f72a0] [PAY-1563] Fix loading into a chat from a push notification (#3699) Michael Piazza
[ea7e3b1] [C-2478 C-2480] Add suggestedTracks (#3689) Dylan Jeffers
[5bb451a] Attach ulid package to window (#3697) Michael Piazza
[23e5b24] Fix track screen artist name font weight (#3695) Reed
[7de914e] [C-2416] Fix missing hidden playlists on own profile (#3694) Dylan Jeffers
[210113d] Fetch chats on app foreground (#3693) Michael Piazza
[16ca56a] [C-2718] Fix mobile sign-up environment issues (#3691) Dylan Jeffers
[65aa97c] Update SDK to v3.0.3-beta.63 (#3688) Michael Piazza
[e8a7c04] OAuth and Developer Apps QA C-2816 C-2815 C-2794 C-2793 C-2795 C-2797 (#3681) nicoback2
[dcd67b9] [C-2465] Improve audius-query cache selection performance (#3687) Dylan Jeffers
[05b1940] [C-2799] Disallow protected m4p file uploads (#3686) Andrew Mendelsohn
[c099918] [PAY-1535] Refresh chat messages on render and pull to refresh on chats list (#3673) Marcus Pasell
[2fccb0b] [CON-765] Default uploads to v2 and remove feature flag (#3679) Theo Ilie
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amendelsohn amendelsohn amendelsohn approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylanjeffers @audius-infra @amendelsohn