This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
[PAY-1545] Updates to mobile gated content track tiles #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schottra
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Is this icon used anywhere else and does removing it break anything?
Seems like just an update to a smaller viewport?
Also wondering if I need to update this icon in web as well...
There was a problem hiding this comment.
I think the icon itself also looks slightly different. Probably also good to change in web!
packages/mobile/src/components/lineup-tile/LineupTilePremiumContentTypeTag.tsx
Show resolved
Hide resolved
packages/mobile/src/components/lineup-tile/LineupTilePremiumContentTypeTag.tsx
Outdated
Show resolved
Hide resolved
packages/mobile/src/components/lineup-tile/LineupTilePremiumContentTypeTag.tsx
Outdated
Show resolved
Hide resolved
| marginRight: 10, | ||
| height: 26 | ||
| paddingVertical: spacing(2), | ||
| marginHorizontal: spacing(2.5) |
There was a problem hiding this comment.
I had thought the design had everything aligned to grid units. Why the 2.5 spacing here?
There was a problem hiding this comment.
oh man i think there's 10px padding on the tile even tho the spec says 8. I think I'll just merge this now and follow-up with another PR to change the padding everywhere and add some client folks to that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useIsGatedContentEnabledin all lineup tile related componentsDragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Screenshots below were taken before I updated the font weight to medium, did not update the screenshots bc i am lazy :)
Local ios stage:
Owner:
How will this change be monitored?
Feature Flags
Not feature-flagged hence merging to feature branch.