-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh interesting for sure. Maybe we chat about it in person for all the context!
would also like to check that the lineup ends and doesn't try to load forever |
Preview this change https://demo.audius.co/sk-fix-profile-lineup |
Good call, there was some weird infinite load behavior at the end of the lineup. I ended up fixing the problem in a different way, it's not very elegant but I didn't want to use Essentially needed to keep track of "deleted" and "removed because of artist pick" separately, I did this by setting the artist pick item as null and keeping track of a |
Preview this change https://demo.audius.co/sk-fix-profile-lineup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tricky for sure! makes sense though
Description
Dragons
This could break lineups
How Has This Been Tested?
Locally against prod, web and ios
How will this change be monitored?
Michael will confirm fix