Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

[C-403] Fix lineup with artist pick #1246

Merged
merged 3 commits into from
Apr 27, 2022
Merged

[C-403] Fix lineup with artist pick #1246

merged 3 commits into from
Apr 27, 2022

Conversation

sliptype
Copy link
Contributor

@sliptype sliptype commented Apr 21, 2022

Description

  • Instead of slicing the artist pick out of the response, set it to null and keep track of the null count to avoid messing up the offset

Dragons

This could break lineups

How Has This Been Tested?

Locally against prod, web and ios

How will this change be monitored?

Michael will confirm fix

Copy link
Contributor

@jowlee jowlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh interesting for sure. Maybe we chat about it in person for all the context!

@jowlee
Copy link
Contributor

jowlee commented Apr 22, 2022

would also like to check that the lineup ends and doesn't try to load forever

@sliptype sliptype changed the title Set containsDeleted true on profile tracks lineup [C-403] Fix lineup with artist pick Apr 25, 2022
@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/sk-fix-profile-lineup

@sliptype
Copy link
Contributor Author

would also like to check that the lineup ends and doesn't try to load forever

Good call, there was some weird infinite load behavior at the end of the lineup. I ended up fixing the problem in a different way, it's not very elegant but I didn't want to use containsDeleted because we are no longer using it anywhere else and updated our endpoints to account for deleted items.

Essentially needed to keep track of "deleted" and "removed because of artist pick" separately, I did this by setting the artist pick item as null and keeping track of a nullCount. This fixes on both web and mobile

@sliptype sliptype requested a review from jowlee April 26, 2022 15:52
@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/sk-fix-profile-lineup

@sliptype sliptype requested a review from dylanjeffers April 26, 2022 21:38
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tricky for sure! makes sense though

@sliptype sliptype merged commit de6b923 into main Apr 27, 2022
@sliptype sliptype deleted the sk-fix-profile-lineup branch April 27, 2022 14:37
@sliptype sliptype mentioned this pull request Apr 29, 2022
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants