Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing path value πŸ‘©β€πŸ”§ #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asmaamirkhan
Copy link

@asmaamirkhan asmaamirkhan commented Apr 2, 2020

πŸ™‹β€β™€οΈ Hello,

  • πŸš€ Thank you for the useful script.
  • πŸ‘€ I've noticed that you made <path> tag's value static, is there any purpose of doing that?
  • πŸ‘©β€πŸ”§ I fixed it by using os.path.join function and the value of sourcepath parameter.

πŸ’« I suggest you to make it dynamic for better integrity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant