Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

rewrite #71

Merged
merged 3 commits into from
Jul 28, 2015
Merged

rewrite #71

merged 3 commits into from
Jul 28, 2015

Conversation

1000ch
Copy link
Member

@1000ch 1000ch commented Jul 25, 2015

  • rewrite with es6
  • add the option to fix string on save
  • remove the missing option (how to apply message type -> default level?)

related to https://github.com/AtomLinter/linter-plus/issues/58

@iam4x
Copy link
Member

iam4x commented Jul 25, 2015

@1000ch I'll take time to review this on Monday, thank's for the hard work 👍

@iam4x iam4x self-assigned this Jul 25, 2015
editor.setText(jscs.fixString(text, path).output);
};

export const provideLinter = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love ES6 syntax, but the function context binding is not needed here.

export function provideLinter() {

^ makes more sense I think.

@steelbrain
Copy link
Contributor

Just a sidenote, but I think it'll make this PR a lot more readable.
Babel allows property initializers, both of these will work

class Something{
  static staticVar = 1
  privateVar = 1
}

so that way this linter class could be written as

class LinterJSCS{
  static Config = {
    executablePath: {type: "string", default: "", description: "Executable Path"}
  }
  static activate(){
    console.log("Package activated")
  }
  static provideLinter(){
    return {
    // .. linter stuff here
    }
  }
}
module.exports LinterJSCS

@iam4x
Copy link
Member

iam4x commented Jul 28, 2015

🚢

iam4x pushed a commit that referenced this pull request Jul 28, 2015
@iam4x iam4x merged commit 75ee03b into AtomLinter:master Jul 28, 2015
@1000ch
Copy link
Member Author

1000ch commented Jul 28, 2015

@iam4x Thank you :)

@williamboman
Copy link

🙌 Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants