This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Fixed #175 #176
Merged
Fixed #175 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Figured out how to run the build locally and fixed it up. |
…h the package's settings.
|
Thanks @casesandberg! |
|
Looks like this hasn't been released yet, I'll push one out 😉. |
|
Published in v3.4.5. |
|
Sorry @Arcanemagus meant to ping you. The permissions are fucked on this computer I am borrowing and wouldn't let me publish. Glad you were able to get it out! |
|
I was planning on getting this pushed out last night, but something came up, so I'm just glad your merging notified me 😉. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
configPathproperty set on theconfigobject by JSCS is done so in a non-enumerable way. So when we useObject.assignto merge this package's settings with JSCS config file settings, it is lost in the shuffle.This problem is kind of stinky. This solution is a little bit of a hack, but IMHO is acceptable because it's limited to
configPath. If this problem arises again with another non-enumerable property, that would be a good time to revisit this.